Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Kubelet without Docker #1547

Closed
mattjmcnaughton opened this issue Feb 9, 2020 · 24 comments
Closed

Building Kubelet without Docker #1547

mattjmcnaughton opened this issue Feb 9, 2020 · 24 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@mattjmcnaughton
Copy link
Contributor

mattjmcnaughton commented Feb 9, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note): Support building the Kubelet without any "Docker-specific" code or dependency on the docker/docker Golang library.
  • Kubernetes Enhancement Proposal: Build Kubelet without Docker #1546
  • Primary contact (assignee): @mattjmcnaughton
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • GA: 1.19 (this change is internal only, so I think we can go "straight to GA").

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 9, 2020
@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented Feb 9, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 9, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 1, 2020

Hi @mattjmcnaughton !

1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

The KEP PR must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

Please let me know and I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 2, 2020

Hi @kikisdeliveryservice !

Our goal is yes (cc @dims ) - see #1728 for the issue to update the KEP.

Thanks for your work on the release squad.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 4, 2020

thanks @mattjmcnaughton is this going to graduate to alpha/beta/GA? Could you update the "Enhancement target" bulletpoint in your first post as well with this info??

@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 4, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 4, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 4, 2020
@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 4, 2020

thanks @mattjmcnaughton is this going to graduate to alpha/beta/GA? Could you update the "Enhancement target" bulletpoint in your first post as well with this info??

Done :)

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 7, 2020

@kikisdeliveryservice - #1728 is going to be merged, which will update the KEP accordingly.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 11, 2020

excellent! thank you @mattjmcnaughton !

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 11, 2020

@kikisdeliveryservice, the PR is merged: kubernetes/kubernetes#87746

Thanks!

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 11, 2020

@dims I'm not super familiar w/ KEP tracking - can/should we close this issue now?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 11, 2020

@dims I'm not super familiar w/ KEP tracking - can/should we close this issue now?

@mattjmcnaughton please keep this issue open as the enhancements team will use it for tracking until we finish up with 1.19

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 11, 2020

Also, once you are satisfied all your criteria have been met, the KEP should be updated as follows: 'status' to implemented and 'last-updated' to the date you are making this change to the KEP.

@savitharaghunathan
Copy link
Member

savitharaghunathan commented May 21, 2020

Hi @mattjmcnaughton - I am Savitha,1.19 Docs lead. Does this enhancement work planned for 1.19 require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 23, 2020

Hi @savitharaghunathan ! This feature is developer facing only, so I don't believe it requires any new docs or modifications to existing docs. Tbh, I'm not sure how to access the 1.19 Enhancement Tracker, so if you are able to update it, that'd be greatly appreciated.

cc @dims @derekwaynecarr just to get a second opinion re the docs - lmk if you disagree :)

@savitharaghunathan
Copy link
Member

savitharaghunathan commented May 26, 2020

Hi @savitharaghunathan ! This feature is developer facing only, so I don't believe it requires any new docs or modifications to existing docs. Tbh, I'm not sure how to access the 1.19 Enhancement Tracker, so if you are able to update it, that'd be greatly appreciated.

Hi @mattjmcnaughton, Thank you for the update. I can update the enhancement tracker sheet for you :)

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 27, 2020

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 28, 2020

Hi @mattjmcnaughton

The work on this KEP seems to already be completed, but as a reminder that the Code Freeze is June 25th. If you do open any other PRs in k/k or elsewhere please link the to this issue so we can track them. :)

Thanks!
The 1.19 Enhancements Team

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented May 28, 2020

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 15, 2020

Hi @mattjmcnaughton !

To follow-up on the email sent to k-dev today, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19

As this is already completed, it's not really applicable, but wanted to let you know. Please let me know if you have any questions. 😄

Best,
Kirsten

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented Jun 16, 2020

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 16, 2020

No problem, Matt!

@kikisdeliveryservice kikisdeliveryservice added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

/milestone clear

(removing this enhancement issue from the v1.19 milestone as the milestone is complete)

@k8s-ci-robot k8s-ci-robot removed this from the v1.19 milestone Sep 11, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

As the enhancement is marked as implemented and this was GA in 1.19 closing this issue.

Again congrats!

@mattjmcnaughton
Copy link
Contributor Author

mattjmcnaughton commented Sep 16, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

4 participants