Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Terminating Endpoints #1669

Open
andrewsykim opened this issue Apr 6, 2020 · 68 comments
Open

Proxy Terminating Endpoints #1669

andrewsykim opened this issue Apr 6, 2020 · 68 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Apr 6, 2020

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 6, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Apr 6, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 6, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 4, 2020

@andrewsykim Based on the discussion it looks like you are still planning this for 1.19? If so I will make sure we track it in the release team.

@andrewsykim
Copy link
Member Author

andrewsykim commented May 5, 2020

@andrewsykim Based on the discussion it looks like you are still planning this for 1.19? If so I will make sure we track it in the release team.

I know there's a lot of other efforts in-flight in SIG Network so no worries if this slips v1.19. Assuming we're happy with what's proposed, I intend to work on this for v1.19

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 5, 2020

We are trying to reduce content and risk in v1.19 so if you can defer to v1.20 that would be best.

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 18, 2020

@andrewsykim Hi Andrew, tomorrow is Enhancements Freeze for 1.19, what's the decision? 1.19 or 1.20?

@andrewsykim
Copy link
Member Author

andrewsykim commented May 18, 2020

Happy to work on this for v1.19, KEP just needs approval/review at this point. If it slips to v1.20 that is okay with me as well :).

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 20, 2020

Enhancements freeze is upon us, deferring to 1.20.

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone May 20, 2020
@fejta-bot
Copy link

fejta-bot commented Aug 18, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Aug 18, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@thockin thockin added this to Proposed in Test-sig-network Sep 4, 2020
@thockin thockin moved this from Proposed to To Do in Test-sig-network Sep 4, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @andrewsykim

Enhancements Lead here, do you still intend to target this for GA in 1.20?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020

Hi @andrewsykim

Pinging again, is this to be included in 1.20?

Thanks
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Hi @andrewsykim @thockin

Another reminder: Enhancements Freeze is next Tuesday October 6th. If you intend for this enhancement to be included, please let me know. This KEP's graduation criteria says it's dependent on #1672 , but #1672 currently does not have any KEP associated with it. So if this were to proceed into 1.20, you would need to update the graduation criteria.

I also note that this KEP seems to be missing the PRR.

Thanks,
Kirsten

@andrewsykim
Copy link
Member Author

andrewsykim commented Sep 30, 2020

Sorry @kikisdeliveryservice this KEP was merged in v1.19, forgot to update the description with a link

@kikisdeliveryservice kikisdeliveryservice added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 30, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Hi @andrewsykim

Thanks for the update. A little confusion bc the graduation criteria says:

The graduation criteria of this KEP will largely depend on the graduation status of the EndpointSlice API. Once the terminating field is added to EndpointSlice API, this change in behavior will kick-in as soon as kube-proxy consumes EndpointSlice.

Is that correct? What do you expect to delivery in this release exactly? Can you update the KEP to provide some clarity?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 2, 2020

@andrewsykim

As a reminder Enhancements Freeze is October 6th, so you will need to update your KEP by that time to lay out the alpha (this release deliverable), alpha->beta, etc... graduation criteria as requested above.

Thanks!
Kirsten

@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 3, 2020

Updated alpha graduation criteria here #2064

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 3, 2020

@andrewsykim This is great and much clearer!! 👍

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 5, 2020

Hi @andrewsykim

Ping!

As a reminder your PR (#2064 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

Best,
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 6, 2020

#2064 merged! Updating tracking sheet now. 😄

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 11, 2020

Hey @andrewsykim

Sincethis Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks!
Kirsten

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jun 22, 2022

@Priyankasaggu11929 why did this and several others just show up in the enhancements sheet?

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 22, 2022

why did this and several others just show up in the enhancements sheet?

Hello @johnbelamaric 👋 , these were opted-in by the SIG Network Leads to the tracking sheet (added to the KEP Collection tab)

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jun 22, 2022

Yeah I know, it's just that they just showed up now. So it makes it very hard to plan when they pop in ~48h before the deadline.

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jun 23, 2022

Is there a PR for this KEP for graduation to beta? I don't see it to review?

@thockin thockin modified the milestones: v1.25, v1.26 Jun 23, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 24, 2022
@bowei
Copy link
Member

bowei commented Aug 28, 2022

/assign

@rhockenbury
Copy link

rhockenbury commented Sep 27, 2022

/label lead-opted-in
/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added lead-opted-in Denotes that an issue has been opted in to a release tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 27, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 27, 2022

Hello @andrewsykim 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@thockin
Copy link
Member

thockin commented Sep 29, 2022

Candidate for Beta in 1.26

@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

Quick reminder - Enhancement freeze is about a week away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README.

@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 4, 2022

Sorry @rhockenbury, I forgot to link this issue in #3505. This KEP should be good for v1.26, let me know if there's anytthing else missing.

@rhockenbury
Copy link

rhockenbury commented Oct 5, 2022

Ok, looks like things are good for enhancements freeze. I have this one marked as tracked now.

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 1, 2022

Hi @andrewsykim 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, open PR in K/K repo. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have any other k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked for code freeze.

As always, we are here to help should questions come up. Thanks!

@thockin thockin moved this from Alpha gated (code is merged) to Beta gated (merged) in SIG-Network KEPs Nov 3, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 7, 2022

Hey @andrewsykim ,

As the Code freeze is just a day away, just wanted to confirm that there are no open PRs in the K/K repo or any repo in general for this enhancement? So that the enhancement can be marked tracked.

@Rishit-dagli
Copy link
Member

Rishit-dagli commented Nov 8, 2022

Hello @andrewsykim 👋 1.26 Release Docs shadow here!

This enhancement is marked as ‘Needs Docs’ for 1.26 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@krol3
Copy link

krol3 commented Nov 14, 2022

Hello @andrewsykim 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 14, 2022

@krol3 does that include feature blog posts?

@Rishit-dagli
Copy link
Member

Rishit-dagli commented Nov 14, 2022

@krol3 does that include feature blog posts?

This deadline only applies for having a PR ready for review in the documentation and not the blog.

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 15, 2022

docs: kubernetes/website#37914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
SIG-Network KEPs
Beta gated (merged)
Development

No branches or pull requests