Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Terminating Endpoints #1672

Open
andrewsykim opened this issue Apr 7, 2020 · 66 comments
Open

Tracking Terminating Endpoints #1672

andrewsykim opened this issue Apr 7, 2020 · 66 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Apr 7, 2020

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 7, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 17, 2020

Based on the issue description,
/sig network

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 17, 2020

@palnabarun: The label(s) sig/ cannot be applied, because the repository doesn't have them

In response to this:

Based on the issue description,
/sig network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 17, 2020
@harshanarayana
Copy link

harshanarayana commented Apr 30, 2020

Hey there @andrewsykim -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@harshanarayana
Copy link

harshanarayana commented May 9, 2020

Hey @andrewsykim, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

@harshanarayana
Copy link

harshanarayana commented May 14, 2020

Hey @andrewsykim , Enhancements team shadow here for the release v1.19 cycle.

I am just following up to see if this enhancement item is still being planned for v1.19 so that we can start tracking the details in the tracker sheet. Please let me know if it is planned to inclusion and I will update the trackers accordingly.

Thanks

@harshanarayana harshanarayana added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020
@harshanarayana
Copy link

harshanarayana commented May 20, 2020

Hey @andrewsykim , Unfortunately the deadline for the 1.19 Enhancement freeze has passed and there is no KEP PR opened/merged in implemetable state yet.. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@fejta-bot
Copy link

fejta-bot commented Aug 18, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@palnabarun
Copy link
Member

palnabarun commented Sep 1, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@thockin thockin added this to Proposed in Test-sig-network Sep 4, 2020
@thockin thockin moved this from Proposed to To Do in Test-sig-network Sep 4, 2020
@thockin thockin moved this from To Do to Proposed in Test-sig-network Sep 4, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

@andrewsykim

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020

Hi @andrewsykim

Enhancements Freeze is October 6th. Currently there is not KEP associated with this Issue. Please advise on whether you intend on working on this for 1.20.

As a reminder to be included in a release:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

Thanks,
Kirsten

@andrewsykim
Copy link
Member Author

andrewsykim commented Sep 30, 2020

Sorry @kikisdeliveryservice this KEP was merged in v1.19, forgot to update the description with a link

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Hi @andrewsykim

Thanks could you clarify the graduation criteria? It links to another KEP whose graduation criteria talks about beta and doesn't seem to mention this ?

As a reminder Enhancements Freeze is next week October 6th , so please update the KEP to have clear graduation criteria by then.

Thanks!
Kirsten
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 30, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 30, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 3, 2020

Updated alpha graduation criteria here #2065

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 3, 2020

@andrewsykim perfect! thank you!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 6, 2020

This merged, updated sheet!

@kendallroden
Copy link
Contributor

kendallroden commented Oct 12, 2020

Hey @andrewsykim!

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks so much,

Kendall

@thockin thockin moved this from Alpha gated (code is merged) to Beta gated (merged) in SIG-Network KEPs Sep 29, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Candidate for GA in 1.26

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 4, 2022

Hey @andrewsykim there's is just one item left on the list I hope to take a look at it before enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 4, 2022

I might be missing something, but the KEP does have an updated test plan: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1672-tracking-terminating-endpoints#test-plan

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 5, 2022

I might be missing something, but the KEP does have an updated test plan: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1672-tracking-terminating-endpoints#test-plan

Hey @andrewsykim,
If you check the latest template, there's an agreement that needs to be checked in the test plan section. And that is missing in this KEP's README.

@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 5, 2022

If you check the latest template, there's an agreement that needs to be checked in the test plan section. And that is missing in this KEP's README.

I see, this KEP was using the old template since it predates the new one.

@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 5, 2022

Opened #3581 to use the new test plan format

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 5, 2022

will mark the kep as tracked once the PR is merged.

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 6, 2022

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 1, 2022

Hi @andrewsykim 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any open k/k PRs. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked for code freeze.

As always, we are here to help should questions come up. Thanks!

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in SIG-Network KEPs Nov 3, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Nov 7, 2022

Hey @andrewsykim,

As the Code freeze is just a day away, just wanted to confirm that there are no open PRs in the K/K repo or any repo in general for this enhancement? So that the enhancement can be marked tracked.

@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @andrewsykim 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze. You must have the related k/k PRs linked to the issue description as a requirement for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Nov 9, 2022
@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 9, 2022

Oops, sorry I forgot to link -- but the PR landed here kubernetes/kubernetes#113363

@krol3
Copy link

krol3 commented Nov 14, 2022

Hello @andrewsykim 👋please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

@andrewsykim
Copy link
Member Author

andrewsykim commented Nov 15, 2022

docs: kubernetes/website#37913

@leonardpahlke
Copy link
Member

leonardpahlke commented Nov 28, 2022

@rhockenbury It looks like all the requirements are met and we can add it back to the milestone
cc @kubernetes/release-team-leads

@leonardpahlke
Copy link
Member

leonardpahlke commented Nov 28, 2022

It looks like we removed this from the K8s 1.26 release cycle because we didn't find the PR that @andrewsykim linked above. The PR was merged a week before the code freeze, so this needs to be added back into the tracking.

/milestone v1.26
/label tracked/yes
/label lead-opted-in
/remove-label tracked/no

FYI release-docs @krol3, release-comms @fsmunoz for tracking

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
SIG-Network KEPs
GA (merged, gate not removed)
Development

No branches or pull requests