Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional validation to Volume Snapshot objects #1900

Closed
AndiLi99 opened this issue Jul 17, 2020 · 18 comments
Closed

Add additional validation to Volume Snapshot objects #1900

AndiLi99 opened this issue Jul 17, 2020 · 18 comments
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@AndiLi99
Copy link
Contributor

AndiLi99 commented Jul 17, 2020

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 17, 2020
@AndiLi99
Copy link
Contributor Author

AndiLi99 commented Jul 17, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 17, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @AndiLi99

Enhancements Lead here. Will this be graduating in 1.20?

Thanks!
Kirsten

@AndiLi99
Copy link
Contributor Author

AndiLi99 commented Sep 15, 2020

Hi!

This feature is targeting 1.20 for GA. cc @msau42

@AndiLi99
Copy link
Contributor Author

AndiLi99 commented Sep 15, 2020

See also #177

@xing-yang
Copy link
Contributor

xing-yang commented Sep 15, 2020

Hi @kikisdeliveryservice,

This goes together with #177.

Thanks!
Xing

@xing-yang xing-yang added this to the v1.20 milestone Sep 15, 2020
@kikisdeliveryservice kikisdeliveryservice added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 15, 2020
@msau42
Copy link
Member

msau42 commented Sep 15, 2020

@xing-yang should we combine the 2 enhancements and treat this as a requirement for the snapshots feature?

@xing-yang
Copy link
Contributor

xing-yang commented Sep 16, 2020

@xing-yang should we combine the 2 enhancements and treat this as a requirement for the snapshots feature?

Yes, that makes sense.

@kikisdeliveryservice, this enhancement is a component of #177. Can we just use 177 to track instead of tracking them separately? Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 16, 2020

Hi @xing-yang

Just to clarify this issue 1900 (which was going straight to stable) is essentially the GA step (and graduation criteria, etc...) for 177?

Thanks!

@xing-yang
Copy link
Contributor

xing-yang commented Sep 16, 2020

Just to clarify this issue 1900 (which was going straight to stable) is essentially the GA step (and graduation criteria, etc...) for 177?

Hi @kikisdeliveryservice, this is one important step we need before moving 177 to GA. There are other things that are required before moving to GA and they are tracked already by 177.

Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 24, 2020

Hi @xing-yang

I gave it some thought and the current setup is confusing and difficult to track.

You put the KEP for this (which uses the old format): https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/tighten-validation-webhook-crd.md in the dir for 177 https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/177-volume-snapshot

Note: the KEP in 177 uses the old format here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/README.md

My suggestion:

The above would make it very clear that 177 is dependent on this KEP but also allow us to properly track both and have the dirs set up correctly.

Please let me know if you have any questions or need any assistance!! As a note Enhancements Freeze is October 6th.

Best,
Kirsten

@xing-yang
Copy link
Contributor

xing-yang commented Sep 24, 2020

Hi @kikisdeliveryservice,

Sure, I'll sort out the dir structure following the new format.

Thanks,
Xing

@xing-yang
Copy link
Contributor

xing-yang commented Sep 26, 2020

Hi @kikisdeliveryservice,

I submitted a PR here to sort out the dir structure for these two enhancement issues:
#1994

Actually the work needed for #1900 will happen out-of-tree, so this can be tracked as tracked/out-of-tree.
While the issue #177 includes in-tree components so that needs to be tracked as tracked/yes.

Will this be more clear?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020

It looks great @xing-yang definitely more clear. Thanks for doing this!! 👍 😄

@kikisdeliveryservice kikisdeliveryservice added tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 27, 2020
@fejta-bot
Copy link

fejta-bot commented Dec 26, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2020
@annajung annajung removed the tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team label Jan 7, 2021
@annajung
Copy link
Member

annajung commented Jan 7, 2021

Hi @xing-yang 1.21 Enhancement Lead here.

I believe this issue can close now with being GA. Before closing, can you update the kep.yaml to reflect a status of implemented:

Once that merges, we can close out this issue.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2021
@xing-yang
Copy link
Contributor

xing-yang commented Jan 7, 2021

Will do. Thanks @annajung for the reminder.

@annajung
Copy link
Member

annajung commented Jan 21, 2021

I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2021

@annajung: Closing this issue.

In response to this:

I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

7 participants