New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IPVS-based in-cluster service load balancing #265

Closed
quinton-hoole opened this Issue Apr 24, 2017 · 33 comments

Comments

@quinton-hoole
Member

quinton-hoole commented Apr 24, 2017

Feature Description

  • One-line feature description (can be used as a release note): Implement IPVS-based in-cluster service load balancing
  • Primary contact (assignee): @m1093782566 (@quinton-hoole acting as proxy as @haibinxie is not yet a member of the K8s org)
  • Responsible SIGs: sig-networking
  • Design proposal link (community repo): See kubernetes/kubernetes#44063
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @thockin @quinton-hoole
  • Approver (likely from SIG/area to which feature belongs): @thockin
  • Initial target stage (alpha/beta/stable) and release (x.y):
    • alpha in v1.8
    • beta in v1.9
    • GA in v1.10

cc: @kubernetes/sig-network-feature-requests

@quinton-hoole quinton-hoole added this to the v1.7 milestone Apr 24, 2017

@quinton-hoole quinton-hoole self-assigned this Apr 24, 2017

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Apr 25, 2017

Is this a dupe / replacement of #196?

@idvoretskyi idvoretskyi added this to In Progress in Kubernetes 1.7 features May 3, 2017

@cmluciano cmluciano modified the milestones: next-milestone, v1.7 May 4, 2017

@cmluciano

This comment has been minimized.

Member

cmluciano commented May 4, 2017

As discussed in SIG-Network meeting, the proposal has not been finalized according to the issues linked in the description. These issues should be addressed prior to an official milestone assignment.

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Jun 7, 2017

I raised a PR about design proposa of supporting ipvs mode for kube-proxy, please check

kubernetes/community#692

@idvoretskyi idvoretskyi removed this from In Progress in Kubernetes 1.7 features Jun 8, 2017

@quinton-hoole quinton-hoole modified the milestones: 1.8, next-milestone Jul 13, 2017

@caseydavenport caseydavenport referenced this issue Jul 13, 2017

Closed

IPvS Option for KubeProxy #196

1 of 23 tasks complete
@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Sep 5, 2017

@quinton-hoole @kubernetes/sig-network-feature-requests any updates for 1.8? Is this feature still on track for the release?

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Sep 18, 2017

@quinton-hoole @kubernetes/sig-network-feature-requests can you confirm that this feature targets 1.8?

If yes, please, update the features tracking spreadsheet with the feature data, otherwise, let's remove this item from 1.8 milestone.

Thanks

@haibinxie

This comment has been minimized.

haibinxie commented Sep 18, 2017

@idvoretskyi yes it's on track for 1.8 after lots of efforts. I see it's already in the spreedsheet item 22. could you double check if it's good?

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Sep 18, 2017

@haibinxie sorry, it's there. Thanks!

@pires

This comment has been minimized.

Member

pires commented Sep 20, 2017

@haibinxie both the document and this issue don't link to any PRs. Can you link here so one can take a look?

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Sep 20, 2017

@pires

Please check PR kubernetes/kubernetes#46580 and design proposal kubernetes/community#692

FYI

@pires

This comment has been minimized.

Member

pires commented Sep 20, 2017

thanks a lot! excited to try this out.

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Sep 20, 2017

Thanks, @pires

Please note that it's still in alpha version and there are already some PRs about small bug fixes in fly, xref:

kubernetes/kubernetes#52014, kubernetes/kubernetes#52330

@luxas

This comment has been minimized.

Member

luxas commented Sep 21, 2017

@m1093782566 Can you please link to the user-facing documentation (kubernetes.io/docs) for this feature?

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Sep 21, 2017

@luxas

Sure. I think @Lion-Wei is already working on it. Could you please provide the link, @Lion-Wei?

@apsinha

This comment has been minimized.

apsinha commented Sep 25, 2017

Would be really good to get some docs. @m1093782566

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Sep 26, 2017

@apsinha

Please check the design proposal: kubernetes/community#692 and user documents: kubernetes/website#5571

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Jan 18, 2018

As we discussed in sig-netork meeting, we are targeting GA in 1.10.

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Jan 18, 2018

@quinton-hoole Would you please re-tag this issue to 1.10 and stage/stable?

@kevin-wangzefeng kevin-wangzefeng modified the milestones: v1.9, v1.10 Jan 18, 2018

@kevin-wangzefeng

This comment has been minimized.

Member

kevin-wangzefeng commented Jan 18, 2018

@m1093782566 updated.

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Jan 18, 2018

Thanks Kevin!

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Feb 14, 2018

@m1093782566 based on the conversation at kubernetes/kubernetes#56319, can you confirm that the feature is still on track for 1.10?

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Feb 14, 2018

we are targetting 1.11 now

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Feb 14, 2018

@m1093782566 please, updated the feature target stage and milestone.

Thanks

@feiskyer feiskyer modified the milestones: v1.10, next-milestone Feb 14, 2018

@feiskyer

This comment has been minimized.

Member

feiskyer commented Feb 14, 2018

Moved milestone out of v1.10.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@cmluciano @m1093782566 @kubernetes/sig-network-feature-requests
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue May 31, 2018

Merge pull request #58442 from m1093782566/ipvs-ga
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Declare IPVS-based kube-proxy GA and remove feature gateway

**What this PR does / why we need it**:

As discussed in sig-network meeting, we decided to target IPVS-based kube-proxy GA in 1.10.

This PR declares IPVS-based kube-proxy GA and remove feature gateway.

**Which issue(s) this PR fixes**:

Fixes: #58443

issue in feature repo: kubernetes/enhancements#265

**Special notes for your reviewer**:

**Release note**:

```release-note
Declare IPVS-based kube-proxy GA
```

@quinton-hoole
@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 2, 2018

@cmluciano @m1093782566 @Lion-Wei @quinton-hoole @kubernetes/sig-network-feature-requests --
We noticed that there was no response on this feature for the 1.11 Release Cycle, yet it's on the 1.11 Features tracking spreadsheet.

At this point, an exception would need to be filed for this to make it into the 1.11 milestone.
Please follow the process detailed here.

In addition, please update the line item for this feature on the Milestone risks sheet ASAP AND ping myself and @idvoretskyi, so we can assess the feature status or we will need to officially remove it from the milestone.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 6, 2018

Exception was approved by @jberkus.
Just noting for record. This has been moved back to the primary sheet.

@justaugustus justaugustus modified the milestones: next-milestone, v1.11 Jun 6, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 27, 2018

Closing this as the feature is GA in 1.11. Please feel free to reopen if there is still a need to track this.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment