Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending dockershim removal to Kubernetes 1.24 instead of 1.23 #2767

Closed
4 tasks
msjingli opened this issue May 24, 2021 · 13 comments
Closed
4 tasks

Extending dockershim removal to Kubernetes 1.24 instead of 1.23 #2767

msjingli opened this issue May 24, 2021 · 13 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@msjingli
Copy link

Enhancement Description

  • One-line enhancement description (can be used as a release note): There're Kubernetes distros and customers who are using docker runtime are struggling to move to ContainerD. Would be appreciated more time for stabilization and validation.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2221-remove-dockershim/README.md
  • Discussion Link:
  • Primary contact (assignee): @dims
  • Responsible SIGs: SIG-Node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.20 (marked as deprecated)
    • Beta release target (x.y): 1.24 (k8s released without dockershim)
    • Stable release target (x.y): 1.24 (dockershim is removed from the codebase)
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 24, 2021
@msjingli
Copy link
Author

#2221, from this link it sounds like dockershim will be removed in Kubernetes 1.24. But in Kubernetes blog (https://kubernetes.io/blog/2020/12/02/dockershim-faq/), dockershim will be removed in 1.23. Can anyone help to confirm? Thanks.

@immuzz
Copy link

immuzz commented May 24, 2021

@aravindhp
Copy link
Contributor

As indicated by @dims, the KEP has been updated to reflect 1.24.

@jsturtevant
Copy link
Contributor

To be clear, this means it will stay in tree for 1.23 but will be removed in 1.24?

@BenTheElder
Copy link
Member

One-line enhancement description (can be used as a release note): There're Kubernetes distros and customers who are using docker runtime are struggling to move to ContainerD. Would be appreciated more time for stabilization and validation.

What happened to cri-dockerd / external dockershim? Just like cloud providers there's no requirement that CRI be in-tree, and there's no requirement to move to containerd speficially.

@mrbobbytables
Copy link
Member

Agree with @BenTheElder, I thought Mirantis was picking up stewardship of dockershim externally?

@dims
Copy link
Member

dims commented May 26, 2021

yep, https://github.com/Mirantis/cri-dockerd is already out.

@dims
Copy link
Member

dims commented May 26, 2021

To be clear, this means it will stay in tree for 1.23 but will be removed in 1.24?

@jsturtevant that's what the KEP currently as checked in says. I am debating if i should do a dockerless kublet in 1.23 (keep the code in-tree but we ship without docker support, so if anyone needs it then they need to build it themselves)

@immuzz
Copy link

immuzz commented May 27, 2021

@dims i think it would make a huge difference for folks using DIY K8s if you can ship in 1.23 with docker support.

@aravindhp
Copy link
Contributor

@dims i think it would make a huge difference for folks using DIY K8s if you can ship in 1.23 with docker support.

+1 to this

@mrbobbytables
Copy link
Member

FYI - this should probably be closed, the associated tracking issue was updated with this information:
#2221

@dims dims closed this as completed May 27, 2021
@msjingli
Copy link
Author

To be clear, this means it will stay in tree for 1.23 but will be removed in 1.24?

@jsturtevant that's what the KEP currently as checked in says. I am debating if i should do a dockerless kublet in 1.23 (keep the code in-tree but we ship without docker support, so if anyone needs it then they need to build it themselves)

@dims can you please confirm that if docker will stay as supported in 1.23 or it's only code in-tree and need to build by whoever wants to use it?

@dims
Copy link
Member

dims commented Jul 22, 2021

@msjingli as of today the plan is for 1.23 will remain the same as 1.22 - please see details in https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2221-remove-dockershim/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

8 participants