Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockershim deprecation timeline in published blog post from K8s v1.23 -> v1.24 #29776

Closed
cwilhit opened this issue Sep 22, 2021 · 6 comments
Assignees
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cwilhit
Copy link

cwilhit commented Sep 22, 2021

This is a Bug Report

Problem:
When the community originally announced deprecation of dockershim in Kubernetes, a FAQ was published detailing the deprecation timeline (link). The timeline as presented states:

It will not be removed before Kubernetes 1.22, meaning the earliest release without dockershim would be 1.23 in late 2021

Since then, the timeline has been revised and extended to 1.24, as found in kubernetes/enhancements#2221. Additionally, the FAQ links out a KEP that is now invalid listed under this section.

As this blog post is likely the first place people will land on when people do a web search, we should at minimum update the KEP link and preferably update the timeline as advertised in the blog post.

Proposed Solution:

  1. Revise the wording in section "when-will-dockershim-be-removed" to say (changes in bold), "It will not be removed before Kubernetes 1.23, meaning the earliest release without dockershim would be 1.24 in early 2022"
  2. Invalid KEP link called out in above section should be changed to point at Removing dockershim from kubelet enhancements#2221

Page to Update:
https://kubernetes.io/blog/2020/12/02/dockershim-faq

@cwilhit cwilhit added the kind/bug Categorizes issue or PR as related to a bug. label Sep 22, 2021
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 22, 2021
@reylejano
Copy link
Member

/assign

@reylejano
Copy link
Member

Created PR #29780 to fix this issue

@sftim
Copy link
Contributor

sftim commented Sep 22, 2021

When we revise published blog articles (and we're not just correcting something that, at the time, we'd have fixed before merge if we'd spotted it), we should clearly call out that we're making changes and retain a mention of what the original text would have said.

This is especially important for key details, such as this one.
/area blog
/remove-kind bug
/triage accepted

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 22, 2021
@sftim
Copy link
Contributor

sftim commented Sep 22, 2021

(The hyperlink to the KEP is uncontroversial - you might want to split that fix into its own PR)

@sftim
Copy link
Contributor

sftim commented Sep 23, 2021

Fixed in #29780, I think
/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closing this issue.

In response to this:

Fixed in #29780, I think
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants