Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dockershim from kubelet #2221

Closed
4 of 12 tasks
SergeyKanzhelev opened this issue Dec 29, 2020 · 27 comments
Closed
4 of 12 tasks

Removing dockershim from kubelet #2221

SergeyKanzhelev opened this issue Dec 29, 2020 · 27 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone

Comments

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Dec 29, 2020

Enhancement Description

<-- uncomment for the next stage

  • Stable
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update(s):
      -->

/sig node

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 29, 2020
@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Dec 29, 2020

/sig node

@fejta-bot
Copy link

fejta-bot commented May 11, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2021
@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented May 11, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 9, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2021
@dims
Copy link
Member

dims commented Aug 9, 2021

/remove-lifecycle stale

@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 7, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@saschagrunert
Copy link
Member

saschagrunert commented Feb 3, 2022

@SergeyKanzhelev I took care of updating the KEP meta in my timezone in #3207

@nate-double-u
Copy link

nate-double-u commented Feb 14, 2022

Hi @SergeyKanzhelev 👋 1.24 Docs lead here.

Usually, I'd reach out to KEP owners with the following message:

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, March 31st, 2022 @ 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

In this case, however, as there is a lot of documentation to be changed and updated, I'll share the project board, and the #sig-docs dockershim project community meeting so the community can follow along.

Thanks!

@katcosgrove
Copy link

katcosgrove commented Feb 24, 2022

Hey there! Comms shadow here. Would y'all like to have this included in the deprecations and removal blog for 1.24? Here's what it looked like for 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Feb 24, 2022

@katcosgrove definitely. @nate-double-u do we need a task on a board to track this?

@nate-double-u nate-double-u added this to Unassigned To Do (Needs People) in Docs - Dockershim Removal Feb 25, 2022
@nate-double-u
Copy link

nate-double-u commented Feb 25, 2022

I've added it to https://github.com/orgs/kubernetes/projects/67, thx for the callout 👍

@chris-short
Copy link

chris-short commented Mar 9, 2022

So is it safe to say this a work in progress?

Also, what does done look like here?

@chris-short
Copy link

chris-short commented Mar 9, 2022

/assign

@sftim
Copy link
Contributor

sftim commented Mar 9, 2022

This KEP is not (yet) implemented, because we have not yet released a version of Kubernetes with the dockershim removed.

@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev commented Mar 10, 2022

I've added it to https://github.com/orgs/kubernetes/projects/67, thx for the callout 👍

@nate-double-u I meant to add specifically this piece of work:

Comms shadow here. Would y'all like to have this included in the deprecations and removal blog for 1.24? Here's what it looked like for 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

@nate-double-u nate-double-u moved this from Unassigned To Do (Needs People) to To Do (People Assigned) in Docs - Dockershim Removal Mar 10, 2022
@gracenng gracenng removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Mar 16, 2022
@gracenng
Copy link
Member

gracenng commented Mar 16, 2022

Hi @SergeyKanzhelev 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

@valaparthvi
Copy link

valaparthvi commented Mar 21, 2022

Hi @SergeyKanzhelev 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@gracenng
Copy link
Member

gracenng commented Mar 21, 2022

Hi @SergeyKanzhelev, I'm marking this enhancements as tracked with referenced to the merged PR: kubernetes/kubernetes#97252

Let me know if there is any other k/k PR I should be aware of here

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 10, 2022

Hello @SergeyKanzhelev 👋, 1.25 Enhancements team here.

This KEP was fully implemented in K8s version 1.24.

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 10, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 8, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 7, 2022
@dims
Copy link
Member

dims commented Sep 7, 2022

/close

we are done!

giphy

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 7, 2022

@dims: Closing this issue.

In response to this:

/close

we are done!

giphy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests