Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate workload controller status #2804

Open
4 tasks
ravisantoshgudimetla opened this issue Jun 28, 2021 · 22 comments
Open
4 tasks

Consolidate workload controller status #2804

ravisantoshgudimetla opened this issue Jun 28, 2021 · 22 comments
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Jun 28, 2021

Enhancement Description

Only deployment controller has status to reflect the state during it's lifecycle. This enhancement extends the scope of those of states to other controllers(DaemonSet and StatefulSet). Please note that while the states are same, their definition may change depending on how workload controller performs operations like updates, deletions etc.

  • One-line enhancement description (can be used as a release note):
  • Kubernetes Enhancement Proposal: Consolidate workload controllers status #2833
  • Discussion Link:
  • Primary contact (assignee):
  • Responsible SIGs:
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y):
    • Beta release target (x.y):
    • Stable release target (x.y):
  • Alpha

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 28, 2021
@salaxander salaxander added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 1, 2021
@salaxander
Copy link

salaxander commented Sep 1, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 1, 2021
@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 1, 2021

Hi @ravisantoshgudimetla! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one we would just need the KEP to merge by enhancements freeze :)

Also, can you update this issue's description when you get a chance to make it easier for us to track. (i.e. link to the KEP PR, one line summary, correct alpha release target)

Thanks!

@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 8, 2021

Hi @ravisantoshgudimetla

Ping! As a reminder your PR (#2833) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything,
Kevin

@soltysh
Copy link
Contributor

soltysh commented Sep 9, 2021

@kevindelgado Ravid and I decide we're drop that from 1.23 milestone, can you remove it also from the tracking sheet as well?

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Sep 9, 2021
@kevindelgado kevindelgado added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 10, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Dec 9, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2021
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Dec 9, 2021

/remove-lifecycle stale

Targeting for 1.24 as alpha.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2021
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 22, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 22, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 26, 2022

Hello @ravisantoshgudimetla @soltysh 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just require updating the open KEP PR #2833 for following & have it merged:

  • update the kep.yaml file in the PR to reflect latest-milestone.

At the moment, the status of this enhancement is marked as at-risk. Please keep this enhancement's issue description up-to-date with appropriate stages & links, for ease of tracking for the release team. Thank you so much! 🙂

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 31, 2022

Hello @ravisantoshgudimetla @soltysh , just a quick check-in again, as we approach the 1.24 enhancements freeze.

Please plan to get #2833 merged before enhancements freeze on Thursday, February 3rd at 18:00pm PT.

For note, the current status of the enhancement is at at-risk. Thank you!

@atiratree
Copy link
Member

atiratree commented Feb 2, 2022

@Priyankasaggu11929 PR should be updated, currently waiting for PRR

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Feb 4, 2022

With KEP PR #2833 merged now, this enhancement is ready for the 1.24 enhancements freeze. 🚀

For note, the status is tracked now in tracking sheet. Thank you!

@mehabhalodiya
Copy link

mehabhalodiya commented Feb 12, 2022

Hi @ravisantoshgudimetla 👋🏻 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @atiratree @ravisantoshgudimetla 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Could you please link any recent PRs for the enhancement in the issue description (if any)? I wasn't able to identify any related PRs on the Kubernetes/Kubernetes repository. Thank you so much!

@mehabhalodiya
Copy link

mehabhalodiya commented Mar 21, 2022

@ravisantoshgudimetla Will you please confirm if you are going to implement this feature in 1.24? Thanks!

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Mar 22, 2022

Hi @mehabhalodiya - We will not get the PR merged this release. The goal is to have the KEP merged this release.

@gracenng
Copy link
Member

gracenng commented Mar 23, 2022

Thanks for the headsup @ravisantoshgudimetla. Removing this feature from the 1.24 release
cc @Priyankasaggu11929

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 23, 2022
@mehabhalodiya
Copy link

mehabhalodiya commented Mar 23, 2022

/milestone clear

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 23, 2022

@mehabhalodiya: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone clear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 23, 2022

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 23, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jun 21, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2022
@atiratree
Copy link
Member

atiratree commented Jul 20, 2022

/remove-lifecycle stale

@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 18, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@atiratree
Copy link
Member

atiratree commented Oct 24, 2022

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests

10 participants