Kubelet Evented PLEG for Better Performance

[harche]

Enhancement Description

• One-line enhancement description (can be used as a release note): Kubelet Evented PLEG for Better Performance
• Kubernetes Enhancement Proposal: KEP-3386: Kubelet Evented PLEG for Better Performance #3387
• Discussion Link: https://kubernetes.slack.com/archives/C03HA69L6R1 ,Add runtime events to CRI kubernetes#110165
• Primary contact (assignee): @harche, @haircommander, @ruiwen-zhao
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.25
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • API Changes - Update CRI API to support Evented PLEG kubernetes#111642
  • KEP (k/enhancements) update PR(s): KEP-3386: Kubelet Evented PLEG for Better Performance #3387
  • Code (k/k) update PR(s): Add Support for Evented PLEG kubernetes#111384
  • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[harche]

/sig-node

[Priyankasaggu11929]

Hello @harche 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

• update the kep.yaml file in the merged KEP to add latest-milestone: "v1.25”

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

[haircommander]

I opened #3410 to target at 1.25

[Priyankasaggu11929]

/sig node

[Priyankasaggu11929]

With KEP PR #3410 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

[Priyankasaggu11929]

Hello @haircommander @harche 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.
  • Add Support for Evented PLEG kubernetes#111384

I was able to find the following draft k/k PRs for the KEP:

• Cri evented pleg approach 1 kubernetes#110911
• Cri evented pleg approach 2 kubernetes#110912

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open/draft k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Thank you for keeping the issue description up-to-date!

[harche]

Thanks @Priyankasaggu11929 for reaching out. I am planning to raise a PR by coming Monday.

[harche]

@Priyankasaggu11929 I just raised a PR - kubernetes/kubernetes#111384

[Priyankasaggu11929]

Hello @harche 👋

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022 (which is almost 2 days from now)

Please plan to have the open k/k PR merged before then.

The status of this enhancement is currently marked as at risk

Thank you

[harche]

API Changes PR - kubernetes/kubernetes#111642

[Priyankasaggu11929]

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

[harche]

@Priyankasaggu11929 Request for the exception has been raised - https://groups.google.com/g/kubernetes-sig-node/c/H_jmCppaurU/m/vwOzc-EFAAAJ

[marosset]

/milestone v1.26
/label lead-opted-in
(I'm doing this on behalf of @ruiwen-zhao / SIG-node)

[rhockenbury]

/stage alpha
/label tracked/yes
/remove-label tracked/no

[derekwaynecarr]

/milestone v1.26
/label lead-opted-in

(this is a carry over from prior release, hope it makes alpha)

[rhockenbury]

Hello @harche, @haircommander, and @ruiwen-zhao 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.26
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to open a PR to make changes to the KEP yaml and KEP readme.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[harche]

@rhockenbury Link to the PR - #3575

[rhockenbury]

Thanks, please plan to get #3575 merged up before enhancements freeze.

[ruiwen-zhao]

@rhockenbury #3575 is now merged and it should check all the boxes in #3386 (comment)

[rhockenbury]

Thanks, I have it marked as tracked now.

[Atharva-Shinde]

Hey @harche @ruiwen-zhao @haircommander 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the issue description above(for tracking purposes). If there are any other PRs beyond:
  Add Support for Evented PLEG kubernetes#111384 and Update CRI API to support Evented PLEG kubernetes#111642 please include them in the issue description too.
• All PRs are fully merged by the code freeze deadline.

As always, we are here to help should questions come up.
Thanks :)

[katmutua]

Hello @harche ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

[harche]

@katmutua Considering this feature is just alpha, I am not sure if we need to have docs.

cc @haircommander @ruiwen-zhao

[krol3]

Hi @harche , here Carol from the Doc Lead of 1.26, I think we need to update the Kubernetes documentation features with alpha, for example here
cc @reylejano

[reylejano]

@harche ,
For 1.26, since this enhancement has a feature gate of EventedPLEG, this should be added to the feature gates page in the Feature gates for Alpha or Beta features table:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

[harche]

Thanks @katmutua @krol3 and @reylejano. I have created a doc PR kubernetes/website#37715 to add EventedPLEG in the features table.

[harche]

cc @swghosh @rphillips

[Atharva-Shinde]

Hey @harche @ruiwen-zhao @haircommander 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow.
Looks like we would at least need to get the code PR/s: kubernetes/kubernetes#111384 (any other PRs?) merged before the code-freeze.

[rhockenbury]

With kubernetes/kubernetes#111384 merged, we have this marked as tracked for code freeze.

[harche]

Hey @harche @ruiwen-zhao @haircommander wave, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: kubernetes/kubernetes#111384 (any other PRs?) merged before the code-freeze.

Not directly a code PR, but there is this doc PR - kubernetes/website#37715