Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Evented PLEG for Better Performance #3386

Open
5 tasks
harche opened this issue Jun 13, 2022 · 30 comments
Open
5 tasks

Kubelet Evented PLEG for Better Performance #3386

harche opened this issue Jun 13, 2022 · 30 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@harche
Copy link
Contributor

harche commented Jun 13, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 13, 2022
@harche
Copy link
Contributor Author

harche commented Jun 13, 2022

/sig-node

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 17, 2022

Hello @harche 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

  • update the kep.yaml file in the merged KEP to add latest-milestone: "v1.25”

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

@haircommander
Copy link
Contributor

haircommander commented Jun 17, 2022

I opened #3410 to target at 1.25

@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 21, 2022
@Priyankasaggu11929 Priyankasaggu11929 added this to the v1.25 milestone Jun 21, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 21, 2022

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 21, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 23, 2022

With KEP PR #3410 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jul 21, 2022

Hello @haircommander @harche 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

I was able to find the following draft k/k PRs for the KEP:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open/draft k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Thank you for keeping the issue description up-to-date!

@harche
Copy link
Contributor Author

harche commented Jul 22, 2022

Thanks @Priyankasaggu11929 for reaching out. I am planning to raise a PR by coming Monday.

@harche
Copy link
Contributor Author

harche commented Jul 25, 2022

@Priyankasaggu11929 I just raised a PR - kubernetes/kubernetes#111384

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 1, 2022

Hello @harche 👋

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022 (which is almost 2 days from now)

Please plan to have the open k/k PR merged before then.

The status of this enhancement is currently marked as at risk

Thank you

@harche
Copy link
Contributor Author

harche commented Aug 2, 2022

API Changes PR - kubernetes/kubernetes#111642

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 3, 2022

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 3, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@harche
Copy link
Contributor Author

harche commented Aug 3, 2022

@marosset
Copy link
Contributor

marosset commented Sep 30, 2022

/milestone v1.26
/label lead-opted-in
(I'm doing this on behalf of @ruiwen-zhao / SIG-node)

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 30, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 1, 2022

/stage alpha
/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 1, 2022
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 3, 2022

/milestone v1.26
/label lead-opted-in

(this is a carry over from prior release, hope it makes alpha)

@rhockenbury
Copy link

rhockenbury commented Oct 3, 2022

Hello @harche, @haircommander, and @ruiwen-zhao 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to open a PR to make changes to the KEP yaml and KEP readme.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@harche
Copy link
Contributor Author

harche commented Oct 4, 2022

@rhockenbury Link to the PR - #3575

@rhockenbury
Copy link

rhockenbury commented Oct 5, 2022

Thanks, please plan to get #3575 merged up before enhancements freeze.

@ruiwen-zhao
Copy link
Contributor

ruiwen-zhao commented Oct 6, 2022

@rhockenbury #3575 is now merged and it should check all the boxes in #3386 (comment)

@rhockenbury
Copy link

rhockenbury commented Oct 6, 2022

Thanks, I have it marked as tracked now.

@Atharva-Shinde
Copy link

Atharva-Shinde commented Oct 31, 2022

Hey @harche @ruiwen-zhao @haircommander 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

As always, we are here to help should questions come up.
Thanks :)

@katmutua
Copy link

katmutua commented Nov 1, 2022

Hello @harche ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@harche
Copy link
Contributor Author

harche commented Nov 3, 2022

@katmutua Considering this feature is just alpha, I am not sure if we need to have docs.

cc @haircommander @ruiwen-zhao

@krol3
Copy link

krol3 commented Nov 3, 2022

Hi @harche , here Carol from the Doc Lead of 1.26, I think we need to update the Kubernetes documentation features with alpha, for example here
cc @reylejano

@reylejano
Copy link
Member

reylejano commented Nov 4, 2022

@harche ,
For 1.26, since this enhancement has a feature gate of EventedPLEG, this should be added to the feature gates page in the Feature gates for Alpha or Beta features table:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

@harche
Copy link
Contributor Author

harche commented Nov 4, 2022

Thanks @katmutua @krol3 and @reylejano. I have created a doc PR kubernetes/website#37715 to add EventedPLEG in the features table.

@harche
Copy link
Contributor Author

harche commented Nov 4, 2022

cc @swghosh @rphillips

@Atharva-Shinde
Copy link

Atharva-Shinde commented Nov 7, 2022

Hey @harche @ruiwen-zhao @haircommander 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow.
Looks like we would at least need to get the code PR/s: kubernetes/kubernetes#111384 (any other PRs?) merged before the code-freeze.

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

With kubernetes/kubernetes#111384 merged, we have this marked as tracked for code freeze.

@harche
Copy link
Contributor Author

harche commented Nov 9, 2022

Hey @harche @ruiwen-zhao @haircommander wave, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: kubernetes/kubernetes#111384 (any other PRs?) merged before the code-freeze.

Not directly a code PR, but there is this doc PR - kubernetes/website#37715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Net New
Development

No branches or pull requests