Kubelet Evented PLEG for Better Performance

[harche]

Enhancement Description

• One-line enhancement description (can be used as a release note): Kubelet Evented PLEG for Better Performance
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3386-kubelet-evented-pleg/README.md
• Discussion Link: https://kubernetes.slack.com/archives/C03HA69L6R1 ,Add runtime events to CRI kubernetes#110165
• Primary contact (assignee): @harche, @haircommander, @ruiwen-zhao
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.25
  • Beta release target (x.y): 1.27
  • Stable release target (x.y):
• Alpha
  • API Changes - Update CRI API to support Evented PLEG kubernetes#111642
  • KEP (k/enhancements) update PR(s): KEP-3386: Kubelet Evented PLEG for Better Performance #3387
  • Code (k/k) update PR(s): Add Support for Evented PLEG kubernetes#111384
• Beta
  • KEP (k/enhancements) update
    • PR(s): KEP-3386: Graduate Evented PLEG to Beta #3817
  • Code (k/k) update PR(s):
    • Graduate Evented PLEG to Beta kubernetes#115967
  • Docs (k/website) updates(s):
    • Graduate Evented PLEG to Beta website#39913

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[harche]

/sig-node

[Priyankasaggu11929]

Hello @harche 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

• update the kep.yaml file in the merged KEP to add latest-milestone: "v1.25”

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

[haircommander]

I opened #3410 to target at 1.25

[Priyankasaggu11929]

/sig node

[Priyankasaggu11929]

With KEP PR #3410 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

[Priyankasaggu11929]

Hello @haircommander @harche 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.
  • Add Support for Evented PLEG kubernetes#111384

I was able to find the following draft k/k PRs for the KEP:

• Cri evented pleg approach 1 kubernetes#110911
• Cri evented pleg approach 2 kubernetes#110912

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open/draft k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Thank you for keeping the issue description up-to-date!

[harche]

Thanks @Priyankasaggu11929 for reaching out. I am planning to raise a PR by coming Monday.

[harche]

@Priyankasaggu11929 I just raised a PR - kubernetes/kubernetes#111384

[Priyankasaggu11929]

Hello @harche 👋

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022 (which is almost 2 days from now)

Please plan to have the open k/k PR merged before then.

The status of this enhancement is currently marked as at risk

Thank you

[harche]

API Changes PR - kubernetes/kubernetes#111642

[Priyankasaggu11929]

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

[harche]

@Priyankasaggu11929 Request for the exception has been raised - https://groups.google.com/g/kubernetes-sig-node/c/H_jmCppaurU/m/vwOzc-EFAAAJ

[marosset]

/milestone v1.26
/label lead-opted-in
(I'm doing this on behalf of @ruiwen-zhao / SIG-node)

[harche]

/label lead-opted-in

[derekwaynecarr]

/milestone v1.27
/label lead-opted-in
/stage beta

[k8s-ci-robot]

@harche: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marosset]

Hello @harche, @haircommander, @ruiwen-zhao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3386 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

[harche]

Hello @harche, @haircommander, @ruiwen-zhao wave, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3386 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@marosset We are aiming to graduate this feature to beta.

[harche]

@marosset I see that this enhancement has been moved to 1.27 tracking board but the tag on this issue still says tracking/no. Not sure if I am missing something.

[harche]

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

[marosset]

This enhancement meets all of the requirements to be included in v1.27 and is now tracked for the release.
Thanks @harche !

[marosset]

Hi @harche, @haircommander, @ruiwen-zhao 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• Graduate Evented PLEG to Beta kubernetes#115967

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

[taniaduggal]

Hi @harche 👋 , I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

[harche]

Thanks @taniaduggal. I have created a PR in k8s/website - kubernetes/website#39913

[SergeyKanzhelev]

Wanted to post it here: https://kubernetes.slack.com/archives/C05KQLJEWHX/p1692383024035069

We see from Containerd that events may overflow and not being send to kubelet. Which will lead to wrong results.

Before moving this forward we need to understand how is it happened and whether we see it in other cases. Loosing events will result in bad outcome and hard to troubleshoot bugs