Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed storage metrics of internal state #496

Closed
gnufied opened this issue Oct 24, 2017 · 25 comments
Closed

Detailed storage metrics of internal state #496

gnufied opened this issue Oct 24, 2017 · 25 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@gnufied
Copy link
Member

gnufied commented Oct 24, 2017

Feature Description

  • Expose detailed metrics of internal state of various storage components
  • Primary contact (assignee): Hemant Kumar (@gnufied)
  • Responsible SIGs: #sig-storage
  • Design proposal link (community repo): Add a proposal for addional volume metrics community#1289
  • Reviewer(s) - @saad-ali @childsb
  • Approver (likely from SIG/area to which feature belongs): #sig-storage
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)
@gnufied
Copy link
Member Author

gnufied commented Oct 24, 2017

@idvoretskyi
Copy link
Member

@gnufied can you fill the "feature target" section please?

@aglitke
Copy link

aglitke commented Oct 24, 2017

Do we want to add a metric for the number of PVs which are attached to unresponsive hosts? This situation indicates bad cluster health which currently requires manual intervention to resolve.

@gnufied
Copy link
Member Author

gnufied commented Oct 26, 2017

@aglitke that sounds like a good idea, we will add it to the google doc.

@gnufied
Copy link
Member Author

gnufied commented Oct 27, 2017

@idvoretskyi since these are basically metrics they go to GA.

@idvoretskyi idvoretskyi added sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Nov 13, 2017
@idvoretskyi idvoretskyi added this to the v1.9 milestone Nov 13, 2017
@idvoretskyi
Copy link
Member

@gnufied based on the conversation above, marking as "stable". Can you confirm?

@gnufied
Copy link
Member Author

gnufied commented Nov 13, 2017

@idvoretskyi yes that is correct.

@zacharysarah
Copy link
Contributor

@gnufied 👋 Please indicate in the 1.9 feature tracking board
whether this feature needs documentation. If yes, please open a PR and add a link to the tracking spreadsheet. Thanks in advance!

@zacharysarah
Copy link
Contributor

@gnufied Bump for docs ☝️

/cc @idvoretskyi

@gnufied
Copy link
Member Author

gnufied commented Nov 29, 2017

We didn't do this for 1.9. Lets bump the milestone for next release.

@saad-ali saad-ali modified the milestones: v1.9, v1.10 Jan 23, 2018
@idvoretskyi idvoretskyi added kind/feature Categorizes issue or PR as related to a new feature. tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 29, 2018
@idvoretskyi
Copy link
Member

@gnufied @saad-ali @kubernetes/sig-storage-feature-requests the feature roadmap is a bit unclear.

Can you update the "Feature target (which target equals to which milestone):" section in the OP?

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Feb 6, 2018
Automatic merge from submit-queue (batch tested with PRs 58317, 58687, 57872, 59063, 59328). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add number measurement for bound/unbound pv/pvc

**What this PR does / why we need it**:

Implement number measurement for bound/unbound pv/pvc defined in the [Metrics Spec](https://docs.google.com/document/d/1Fh0T60T_y888LsRwC51CQHO75b2IZ3A34ZQS71s_F0g/edit#heading=h.bwzmc2tktae)

ref feature: [ kubernetes/enhancements#496](kubernetes/enhancements#496)

**Release note**:

```release-note
Intended for post-1.9
```
@Bradamant3
Copy link
Contributor

@gnufied Can you please update docs for 1.10? Also 1.10 feature tracking spreadsheet
Thanks!

@idvoretskyi
Copy link
Member

@gnufied @saad-ali @kubernetes/sig-storage-feature-requests can you confirm that this feature is delivered in v1.10?

@Bradamant3
Copy link
Contributor

@gnufied @saad-ali @kubernetes/sig-storage-feature-requests Friday March 9 is the deadline for docs PRs to be merged. Is this feature going to stable into v1.10? If so, we need docs urgently. If not, please let us know! Thanks!

@saad-ali
Copy link
Member

saad-ali commented Mar 9, 2018

This does not need to be tracked for 1.10 milestone

@saad-ali saad-ali removed this from the v1.10 milestone Mar 9, 2018
@idvoretskyi
Copy link
Member

@saad-ali can you provide the estimated roadmap for the feature?

@redbaron
Copy link

This feature was specifically mentioned in 1.10 release notes, but was it actually done or just planned to be done in 1.10 at some point?

@gnufied
Copy link
Member Author

gnufied commented Mar 28, 2018

@redbaron This feature in general tracks, general improvement to metrics we emit from storage components. In 1.10 we added additional metrics (namely bound/unbound volume count). In 1.11 the plan is to introduce new metrics that expose problematic state for ease of debugging.

@idvoretskyi
Copy link
Member

@redbaron the release notes fix was pushed, thanks for noticing - kubernetes/kubernetes#61840

@gnufied per @saad-ali the progress that was made on this feature hasn't been major enough to be tracked under the features list of 1.10 release.

@idvoretskyi
Copy link
Member

@saad-ali @k8s-mirror-storage-feature-requests any plans for 1.11?

cc @justaugustus

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2018
@redbaron
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2018
@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 29, 2018
@justaugustus
Copy link
Member

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@justaugustus justaugustus added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 4, 2018
@kacole2
Copy link

kacole2 commented Sep 28, 2018

This issue hasn't had any attention for 1.11 or 1.12. I'm going to close it since the k/commnunity proposal has been closed as well.

/close

@k8s-ci-robot
Copy link
Contributor

@kacole2: Closing this issue.

In response to this:

This issue hasn't had any attention for 1.11 or 1.12. I'm going to close it since the k/commnunity proposal has been closed as well.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.