New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE PD topology support #558

Closed
verult opened this Issue Apr 12, 2018 · 25 comments

Comments

Projects
None yet
@verult
Copy link

verult commented Apr 12, 2018

Feature Description

  • One-line feature description (can be used as a release note): GCE PD topology support
  • Primary contact (assignee): @msau42
  • Responsible SIGs: sig-storage
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s): @saad-ali @verult
  • Approver (likely from SIG/area to which feature belongs): @saad-ali
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.12
    • Beta release target (x.y) 1.13
    • Stable release target (x.y) 1.14
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Apr 12, 2018

/assign
/assign @verult

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

@msau42 @verult -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jun 4, 2018

This has been deferred to 1.12

@saad-ali saad-ali modified the milestones: v1.11, v1.12 Jun 4, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

Thanks for the update, @msau42!

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

@msau42 @verult @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jul 18, 2018

Yes, we are targeting 1.12

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

Thanks for the update, @msau42!

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Aug 20, 2018

Doc placeholder: kubernetes/website#9939

@zparnold

This comment has been minimized.

Copy link
Member

zparnold commented Aug 20, 2018

Thanks!

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Aug 23, 2018

@justaugustus this was mistakenly marked as alpha. It should be beta, as this is part of the larger topology feature, which is moving to beta. #561

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Aug 29, 2018

Thanks for the update, @msau42!
/remove-stage alpha
/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta and removed stage/alpha labels Aug 29, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

@msau42 @verult --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Sep 5, 2018

Yes this feature will be beta in 1.12. According to the 1.12 release schedule, docs PRs are not due until the 7th: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.12

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

Got it. Thanks for the update!

@claurence

This comment has been minimized.

Copy link

claurence commented Oct 5, 2018

Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Oct 5, 2018

Yes, we plan to move this to GA in 1.13.

@saad-ali saad-ali modified the milestones: v1.12, v1.13 Oct 5, 2018

@kacole2 kacole2 added stage/stable and removed stage/beta labels Oct 5, 2018

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Oct 17, 2018

@kacole2 this is still listed as beta in the spreadsheet

@AishSundar

This comment has been minimized.

Copy link

AishSundar commented Oct 17, 2018

@msau42 is there a list of pending PRs or issues you are tracking for this feature to go to GA? Is this related to #561 ?

@jimangel

This comment has been minimized.

Copy link
Member

jimangel commented Oct 17, 2018

@msau42 will the docs change at all after going GA (1.13)?

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Oct 17, 2018

This feature is a subset of #490, but doesn't have any separate tasks that aren't already covered. Would it be easier to close this and just track #490?

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Oct 17, 2018

The only changes needed to the docs are to remove the beta designation.

@kacole2

This comment has been minimized.

Copy link
Contributor

kacole2 commented Oct 18, 2018

@msau42 i'm in favor of tracking at #490 is @AishSundar is. In addition, I'm assuming this is an in-tree driver and not CSI/out of tree?

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Oct 18, 2018

Correct, CSI support is being tracked as an independent feature.

@kacole2

This comment has been minimized.

Copy link
Contributor

kacole2 commented Oct 18, 2018

since we closed out AWS. Let's follow along here. thanks for the explanation
/milestone clear
/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 18, 2018

@kacole2: Closing this issue.

In response to this:

since we closed out AWS. Let's follow along here. thanks for the explanation
/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Oct 18, 2018

@kacole2 kacole2 removed the tracked/yes label Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment