New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology Aware Volume Scheduling #490

Open
msau42 opened this Issue Oct 20, 2017 · 24 comments

Comments

@msau42
Member

msau42 commented Oct 20, 2017

Feature Description

/assign

@fejta-bot

This comment has been minimized.

fejta-bot commented Jan 22, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@msau42

This comment has been minimized.

Member

msau42 commented Jan 22, 2018

/remove-lifecycle-stale
/lifecycle frozen

I'm hoping to target beta in 1.10

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 29, 2018

@msau42 1.10 - beta, right?

@msau42

This comment has been minimized.

Member

msau42 commented Jan 29, 2018

Yes, at least I will try to.

@msau42

This comment has been minimized.

Member

msau42 commented Feb 27, 2018

1.10 Beta PR has been merged: kubernetes/kubernetes#59391

1.11 design for dynamic provisioning is here: kubernetes/community#1857

@mightwork

This comment has been minimized.

mightwork commented Apr 16, 2018

@msau42 In my use case, the statefulset does not automatically schedule pods on the same node as the pv(local storage). To overcome this I have written a custom scheduler that schedules the pod on the node which has it's pv. This also works in the case where the pod goes down and needs to be brought up on the exact node that has it's pv.
Will the changes planned for 1.11 eliminate the need for a custom scheduler or is there a better way to do this?

@msau42

This comment has been minimized.

Member

msau42 commented Apr 16, 2018

@mightwork the current feature should already be scheduling your pod to the correct node. Can you open an issue with the details of your PV and ping me?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@msau42
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@msau42

This comment has been minimized.

Member

msau42 commented Apr 17, 2018

Plan is to remain beta in 1.11.

#561 is tracking the dynamic provisioning work

@justaugustus justaugustus modified the milestones: next-milestone, v1.10 Apr 17, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

Thanks for the update, @msau42!

@justaugustus justaugustus removed this from the v1.10 milestone Jul 1, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 30, 2018

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@msau42

This comment has been minimized.

Member

msau42 commented Jul 30, 2018

Plan for 1.12 is to remain in beta. There are some bugs that need to be fixed before going GA

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 8, 2018

Hi @msau42
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

@msau42

This comment has been minimized.

Member

msau42 commented Oct 8, 2018

Plan for 1.13 is to go GA

@kacole2 kacole2 added tracked/yes and removed tracked/no labels Oct 8, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 8, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 8, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@msau what work if left in k/k for this feature to go to GA in 1.13? Is there a list of pending PRs (code, tests and docs) that we can track on our end?

/stage stable

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@kacole2 I updated the stage to be stable as per Michelle's comment here

@msau42

This comment has been minimized.

Member

msau42 commented Oct 17, 2018

Remaining tasks:

@npentrel

This comment has been minimized.

npentrel commented Oct 25, 2018

Hi @msau42, I'm Naomi and working on docs for the 1.13 release. Could you open up a docs PR against the dev-1.13 branch as a placeholder for the needed docs updates?

@msau42

This comment has been minimized.

Member

msau42 commented Oct 25, 2018

Docs pr here: kubernetes/website#10736

@guineveresaenger

This comment has been minimized.

guineveresaenger commented Nov 5, 2018

Hi @msau42 - I'm Enhancements Shadow for 1.13. Could you please update the release team with the likelihood of this enhancement making the 1.13 release? When we don't see any updates in a few days, we would appreciate an update.

Code slush begins on 11/9 and code freeze is 11/15.

Thank you!

@msau42

This comment has been minimized.

Member

msau42 commented Nov 5, 2018

Yes, this is on track to meet code freeze.

e2e PR is close to being merged:
kubernetes/kubernetes#70362

I will open up the feature gate PR this week.

@AishSundar

This comment has been minimized.

AishSundar commented Nov 12, 2018

@msau42 is the e2e test PR the only pending PR for this enhancement? I added milestone and priority to the PR so it can merge in Slush.

Is there a feature gate PR open?

@msau42

This comment has been minimized.

Member

msau42 commented Nov 12, 2018

I updated the checklist above. Just docs are remaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment