aws-alb-ingress-controller alpha

[d-nishi]

Feature Description

• One-line feature description (can be used as a release note): The AWS ALB Ingress Controller satisfies Kubernetes ingress resources by provisioning Application Load Balancers.
• Primary contact (assignee): @M00nF1sh
• Responsible SIGs: SIG-AWS
• Design proposal link (community repo): https://github.com/M00nF1sh/community/blob/master/contributors/design-proposals/aws/alb_ingress_controller.md
• Link to e2e and/or unit tests: unit tests (https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/master/.travis.yml#L27) and more to come; e2e to come
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bigkraig @justinsb
• Approver (likely from SIG/area to which feature belongs): @d-nishi
• Feature target (which target equals to which milestone):
  • Alpha release target (1.13)
  • Beta release target (1.14)
  • Stable release target (1.15)

[d-nishi]

/sig aws

[d-nishi]

/assign @M00nF1sh @d-nishi

[kacole2]

coming in hot under the wire here :)
I know this is out of tree and there won't be any k/k merges so will track it for 1.13 for anyone that wants to follow

/milestone v1.13
/stage alpha

[d-nishi]

@kacole2 Thanks! :)

[ameukam]

Hi @d-nishi and @M00nF1sh, I'm Enhancements Shadow for 1.13. Could you please update the release team with the progression of this enhancement for the 1.13 release?

Code slush begins on 11/9 and code freeze is 11/15.

Thank you!

[d-nishi]

@ameukam here are the details of our progress:

1. code is ready.
2. CI signal is visible in https://testgrid.k8s.io/sig-aws-alb-ingress-controller
3. Docs are updated here: https://github.com/kubernetes-sigs/aws-alb-ingress-controller/tree/master/docs

What else do you need for us to show?

[d-nishi]

/kind feature

[claurence]

@d-nishi Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - it looks like this issue has a KEP here https://github.com/kubernetes/enhancements/blob/master/keps/sig-aws/draft-20181127-aws-alb-ingress-controller.md - is that the correct KEP for this issue.

[d-nishi]

@claurence is the ask to commit to a beta release for the feature before Jan 29th?

Yes the KEP is correct. We will update it with some additional data before Jan 29th.

[claurence]

@d-nishi to clarify the ask is to understand what status you are planning for this issue in the 1.14 release cycle. If that is beta I'll make sure we have that as the status being tracked. Thanks!

[d-nishi]

@claurence yes it is beta!

[claurence]

@d-nishi the KEP for this is marked as "provisional" - what open work is required for it to be "implementable"?

Additionally - what open PRs in k/k should be tracked for 1.14? Code Freeze is on March 7th an all PRs need to be merged by that date.

[M00nF1sh]

@claurence
The current left open work for 1.14 is only have e2e test for alb ingress controller. I'll make it before code freeze 😄

[claurence]

Thanks! Is there a link to the PR for that? Want to make sure all PRs are linked in the tracking sheet

[M00nF1sh]

@claurence
Sorry for the late reply, missed this notification.

The PR to kubernetes/testinfra is merged: kubernetes/test-infra#11354
The PR in our sub-project repo is WIP: kubernetes-sigs/aws-load-balancer-controller#852

[spiffxp]

/milestone clear
I'm removing this from the milestone for the same reasons mentioned in #630 (comment)

tl;dr since it sounds like this enhancements consists of bits cut from an out-of-tree repo, and the release team is only focused on kubernetes/kubernetes, we're not going to track this

If there is (non-test) code in kubernetes/kubernetes that is necessary to make this plugin or out-of-tree enhancement work, please let us know

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[evillgenius75]

Hi @d-nishi @M00nF1sh , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

I noticed the KEP is still in provisional state. As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.