Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GMSA for Windows workloads #689

Closed
ddebroy opened this issue Jan 15, 2019 · 58 comments
Closed

Support GMSA for Windows workloads #689

ddebroy opened this issue Jan 15, 2019 · 58 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@ddebroy
Copy link
Member

ddebroy commented Jan 15, 2019

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 15, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Jan 15, 2019

/sig windows auth node

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 15, 2019
@claurence
Copy link

claurence commented Jan 16, 2019

@ddebroy - Hi I'm the enhancements lead for 1.14 - it looks like this issue is targeting Alpha for 1.14. Just want to remind that enhancements freeze is 1/29

@ddebroy
Copy link
Member Author

ddebroy commented Jan 16, 2019

/milestone v1.14

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 16, 2019

@ddebroy: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@claurence
Copy link

claurence commented Jan 17, 2019

/milestone v1.14

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 17, 2019

@claurence: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@claurence claurence added this to the v1.14 milestone Jan 22, 2019
@claurence claurence added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 22, 2019
@claurence
Copy link

claurence commented Jan 22, 2019

@ddebroy are there any open PRs that should be tracked for this issue for the 1.14 release?

@ddebroy
Copy link
Member Author

ddebroy commented Jan 22, 2019

@claurence we were trying to lock down the design and get to implementable state for the KEP this week (#694, #710 and #722).

We will have PRs for the alpha implementations out shortly.

@claurence claurence added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 23, 2019
@PatrickLang PatrickLang added this to Backlog (v1.14) in SIG-Windows Jan 29, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Jan 30, 2019

With #710 merged, the feature should now be in approved/implementable state.

@liggitt liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 31, 2019
@ddebroy ddebroy moved this from Backlog (v1.14) to In Progress (v.1.14) in SIG-Windows Feb 7, 2019
@ddebroy ddebroy moved this from In Progress (v.1.14) to Backlog (v1.14) in SIG-Windows Feb 7, 2019
@PatrickLang PatrickLang moved this from Backlog (v1.14) to In Progress (v.1.14) in SIG-Windows Feb 7, 2019
@liggitt liggitt self-assigned this Feb 14, 2019
@liggitt
Copy link
Member

liggitt commented Feb 14, 2019

I'll take API review on this (if there ends up being any for the alpha version) since I have context on the KEP

@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2019
@ddebroy
Copy link
Member Author

ddebroy commented Feb 20, 2019

In-tree PR tracking the Alpha enhancements implemented through annotations and dockershim: https://github.com/kubernetes/kubernetes/pull/73726/files

@liggitt liggitt removed this from Assigned in API Reviews Feb 20, 2019
@npentrel
Copy link

npentrel commented Feb 22, 2019

Hey @ddebroy 👋! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@ddebroy
Copy link
Member Author

ddebroy commented Feb 27, 2020

Docs placeholder PR: kubernetes/website#19349
Feature Graduation PR: kubernetes/kubernetes#88654

@palnabarun
Copy link
Member

palnabarun commented Mar 3, 2020

Hi @ddebroy, this a reminder that we are just two days away from Code Freeze on 5th March.

By the Code Freeze, kubernetes/kubernetes#88654 should be merged else you would need to file an exception request.

@PatrickLang PatrickLang moved this from Backlog (v1.18) to In Progress (v1.18) in SIG-Windows Mar 3, 2020
@marosset marosset moved this from In Progress (v1.18) to In Review (v1.18) in SIG-Windows Mar 5, 2020
@palnabarun
Copy link
Member

palnabarun commented Mar 23, 2020

Hi @ddebroy, since this enhancement graduated to Stable this release 🚀, the status can now be set to be Implemented.

Can you please update the status? After that, we will close this issue.

@ddebroy ddebroy moved this from In Review (v1.18) to Done (v1.18) in SIG-Windows Mar 23, 2020
@ddebroy
Copy link
Member Author

ddebroy commented Mar 23, 2020

@palnabarun done at #1626

@palnabarun
Copy link
Member

palnabarun commented Mar 23, 2020

Thank you @ddebroy :)

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 17, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/milestone clear

(removing this enhancement issue from the v1.18 milestone as the milestone is complete)

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Apr 29, 2020
@fejta-bot
Copy link

fejta-bot commented Jul 28, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2020
@fejta-bot
Copy link

fejta-bot commented Aug 27, 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 27, 2020
@LorbusChris
Copy link
Contributor

LorbusChris commented Aug 31, 2020

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 31, 2020
@LorbusChris
Copy link
Contributor

LorbusChris commented Aug 31, 2020

Looks like this has been implemented. Can this issue be closed now?

@marosset
Copy link
Contributor

marosset commented Sep 14, 2020

@LorbusChris - yes we can close this now. (sorry, just saw this issue)

@marosset
Copy link
Contributor

marosset commented Sep 14, 2020

/stage stable
/close

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 14, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 14, 2020

@marosset: Closing this issue.

In response to this:

/stage stable
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests