EndpointSlice 1.22 Docs Update (KEP 752) #28745

swetharepakula · 2021-07-02T01:21:41Z

This PR includes the doc updates required since EndpointSlice is going GA in 1.22.

KEP: EndpointSlice Enhancement: EndpointSlice KEP
Enhancement Issue: EndpointSlice API enhancements#752
Relevant Kubernetes PRs:

netlify · 2021-07-02T01:21:45Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 1168b46

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61005c5b66a0a6000809b8ec

content/en/docs/reference/command-line-tools-reference/feature-gates.md

PI-Victor · 2021-07-02T10:22:24Z

thank you for opening this, please remember to hold until the enhancement is no longer labelled 'At Risk'.

/sig network
/assign @ritpanjw

sftim · 2021-07-08T23:36:18Z

kubernetes/kubernetes#103596 suggests this PR might also need to cover EndpointSliceTerminatingCondition.

swetharepakula · 2021-07-09T00:32:01Z

The enhancement is no longer at risk. All relevant PRs were merged yesterday.

This PR is to cover the changes related to kubernetes/enhancements#752

kubernetes/kubernetes#103596 is for a different KEP. I believe EndpointSliceTerminatingCondition is for kubernetes/enhancements#1672 and will be covered by a different docs PR

ritpanjw · 2021-07-16T00:43:13Z

Hello @swetharepakula 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 20th of July, 11:59 PM PDT. In comments, you mentioned it is WIP, hence sending reminder. Thank you!

PI-Victor · 2021-07-20T14:40:22Z

Hello @swetharepakula 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 20th of July, 11:59 PM PDT. In comments, you mentioned it is WIP, hence sending reminder. Thank you!

Hi @swetharepakula friendly reminder that today is the deadline for PRs ready for review, please make sure this PR is ready for review by the end of the day, thank you!

swetharepakula · 2021-07-20T20:46:25Z

Thanks for the reminder @ritpanjw & @PI-Victor! The PR is now ready for review

swetharepakula · 2021-07-20T20:47:04Z

/cc @robscott @aojea

aojea · 2021-07-20T22:40:04Z

LGTM

robscott · 2021-07-20T23:22:32Z

Usually, the way we'd help readers is by advising them to check they're viewing the docs for their version of Kubernetes.
We can backport advice to older docs revisions if that makes sense to do so.

Thanks for the quick response @sftim! That approach makes sense to me. I think the docs for 1.21 are already sufficient here.

kbhawkey · 2021-07-20T23:38:57Z

content/en/docs/concepts/services-networking/service.md

-cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: warning`.
-This annotation indicates that the affected Endpoints object is over capacity.
+If an Endpoints resource has more than 1000 endpoints then a Kubernetes v1.22 (or later)
+cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: truncated`.


nit: Can you be more specific? What annotates the Endpoints resource?

Added a small addition stating that the endpoint controller truncates the resource. Please let me know if you think we should expand more. I am not sure how detailed I should be here.

“the control plane has truncated” would be fine.

content/en/docs/reference/labels-annotations-taints.md

sftim · 2021-07-21T08:34:48Z

content/en/docs/concepts/services-networking/service.md

@@ -188,9 +188,10 @@ selectors and uses DNS names instead. For more information, see the
 [ExternalName](#externalname) section later in this document.

 ### Over Capacity Endpoints
-If an Endpoints resource has more than 1000 endpoints then a Kubernetes v1.21 (or later)


We should maybe edit the v1.21 docs (either now or post release) to remove the “or later” part from the v1.21 docs. WDYT @swetharepakula ?

Oh that is a good point! I can send in a followup pr for that. Which branch would that pr need to be against?

At the moment, that is the main branch: commits there are continuously published to https://kubernetes.io/

PR to update existing 1.21 docs: #29122

sftim · 2021-07-23T07:54:15Z

Next step is a tech review from SIG Network
@kubernetes/sig-network-pr-reviews please check this one out - it should be straightforward to verify.

sftim

/lgtm

sftim · 2021-07-26T17:20:22Z

content/en/docs/concepts/services-networking/service.md

-cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: warning`.
-This annotation indicates that the affected Endpoints object is over capacity.
+If an Endpoints resource has more than 1000 endpoints then a Kubernetes v1.22 (or later)
+cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: truncated`.


“the control plane has truncated” would be fine.

k8s-ci-robot · 2021-07-26T17:20:50Z

LGTM label has been added.

Git tree hash: 6bccddd1d29f71c3b65153eb6bf13c04253d06e3

sftim · 2021-07-26T21:57:43Z

/approve
/hold
Release docs folks, feel free to unhold

k8s-ci-robot · 2021-07-26T21:57:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PI-Victor · 2021-07-27T14:34:40Z

@swetharepakula can you please rebase, a fix to the feature gates table was merged and caused this to conflict.

* Graduate proxying gates * Endpoints Controller truncates endpoints to 1000 and sets over-capacity annotation to `truncated`

swetharepakula · 2021-07-27T19:20:23Z

PR has been rebased.

Is there anything left for this PR? Or do we still need the hold?

PI-Victor · 2021-07-27T19:22:20Z

a tech LGTM from @kubernetes/sig-network-pr-reviews is all that is needed, when this is done we can remove the hold.

sftim · 2021-07-27T21:47:38Z

We have the tech review I think: #28745 (comment)
/hold cancel

sftim · 2021-07-27T21:48:24Z

/lgtm

k8s-ci-robot · 2021-07-27T21:48:29Z

LGTM label has been added.

Git tree hash: b344b66b4a425a01e768b284bef3ff202c42039a

k8s-ci-robot added this to the 1.22 milestone Jul 2, 2021

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2021

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2021

k8s-ci-robot requested review from celestehorgan and kbhawkey July 2, 2021 01:22

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 2, 2021

swetharepakula mentioned this pull request Jul 2, 2021

EndpointSlice API kubernetes/enhancements#752

Closed

aojea reviewed Jul 2, 2021

View reviewed changes

content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved

k8s-ci-robot assigned ritpanjw Jul 2, 2021

k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jul 2, 2021

swetharepakula force-pushed the eps-1.22 branch from dea3acc to 9e6c8ad Compare July 20, 2021 20:39

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2021

swetharepakula changed the title ~~EndpointSlice 1.22 Docs Update~~ EndpointSlice 1.22 Docs Update (KEP 752) Jul 20, 2021

swetharepakula force-pushed the eps-1.22 branch from 9e6c8ad to b707203 Compare July 20, 2021 20:43

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2021

swetharepakula marked this pull request as ready for review July 20, 2021 20:45

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021

k8s-ci-robot requested a review from aojea July 20, 2021 20:47

kbhawkey reviewed Jul 20, 2021

View reviewed changes

content/en/docs/reference/labels-annotations-taints.md Outdated Show resolved Hide resolved

sftim reviewed Jul 21, 2021

View reviewed changes

swetharepakula force-pushed the eps-1.22 branch from b707203 to e872eec Compare July 22, 2021 23:49

sftim reviewed Jul 26, 2021

View reviewed changes

k8s-ci-robot assigned sftim Jul 26, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021

swetharepakula mentioned this pull request Jul 26, 2021

Update EPS docs to indicate behavior is unique to 1.21 #29122

Merged

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021

EndpointSlice 1.22 Docs Update

1168b46

* Graduate proxying gates * Endpoints Controller truncates endpoints to 1000 and sets over-capacity annotation to `truncated`

swetharepakula force-pushed the eps-1.22 branch from e872eec to 1168b46 Compare July 27, 2021 19:19

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021

k8s-ci-robot merged commit 8518607 into kubernetes:dev-1.22 Jul 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EndpointSlice 1.22 Docs Update (KEP 752) #28745

EndpointSlice 1.22 Docs Update (KEP 752) #28745

swetharepakula commented Jul 2, 2021 •

edited

Loading

netlify bot commented Jul 2, 2021 •

edited

Loading

PI-Victor commented Jul 2, 2021

sftim commented Jul 8, 2021

swetharepakula commented Jul 9, 2021

ritpanjw commented Jul 16, 2021 •

edited

Loading

PI-Victor commented Jul 20, 2021

swetharepakula commented Jul 20, 2021

swetharepakula commented Jul 20, 2021

aojea commented Jul 20, 2021

robscott commented Jul 20, 2021

kbhawkey Jul 20, 2021

swetharepakula Jul 22, 2021

sftim Jul 26, 2021

sftim Jul 21, 2021

swetharepakula Jul 22, 2021 •

edited

Loading

sftim Jul 23, 2021

swetharepakula Jul 26, 2021 •

edited

Loading

sftim commented Jul 23, 2021

sftim left a comment

sftim Jul 26, 2021

k8s-ci-robot commented Jul 26, 2021

sftim commented Jul 26, 2021

k8s-ci-robot commented Jul 26, 2021

PI-Victor commented Jul 27, 2021 •

edited

Loading

swetharepakula commented Jul 27, 2021

PI-Victor commented Jul 27, 2021

sftim commented Jul 27, 2021

sftim commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

EndpointSlice 1.22 Docs Update (KEP 752) #28745

EndpointSlice 1.22 Docs Update (KEP 752) #28745

Conversation

swetharepakula commented Jul 2, 2021 • edited Loading

netlify bot commented Jul 2, 2021 • edited Loading

PI-Victor commented Jul 2, 2021

sftim commented Jul 8, 2021

swetharepakula commented Jul 9, 2021

ritpanjw commented Jul 16, 2021 • edited Loading

PI-Victor commented Jul 20, 2021

swetharepakula commented Jul 20, 2021

swetharepakula commented Jul 20, 2021

aojea commented Jul 20, 2021

robscott commented Jul 20, 2021

kbhawkey Jul 20, 2021

Choose a reason for hiding this comment

swetharepakula Jul 22, 2021

Choose a reason for hiding this comment

sftim Jul 26, 2021

Choose a reason for hiding this comment

sftim Jul 21, 2021

Choose a reason for hiding this comment

swetharepakula Jul 22, 2021 • edited Loading

Choose a reason for hiding this comment

sftim Jul 23, 2021

Choose a reason for hiding this comment

swetharepakula Jul 26, 2021 • edited Loading

Choose a reason for hiding this comment

sftim commented Jul 23, 2021

sftim left a comment

Choose a reason for hiding this comment

sftim Jul 26, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 26, 2021

sftim commented Jul 26, 2021

k8s-ci-robot commented Jul 26, 2021

PI-Victor commented Jul 27, 2021 • edited Loading

swetharepakula commented Jul 27, 2021

PI-Victor commented Jul 27, 2021

sftim commented Jul 27, 2021

sftim commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

swetharepakula commented Jul 2, 2021 •

edited

Loading

netlify bot commented Jul 2, 2021 •

edited

Loading

ritpanjw commented Jul 16, 2021 •

edited

Loading

swetharepakula Jul 22, 2021 •

edited

Loading

swetharepakula Jul 26, 2021 •

edited

Loading

PI-Victor commented Jul 27, 2021 •

edited

Loading