Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-preempting option to PriorityClasses #902

Closed
vllry opened this issue Mar 18, 2019 · 82 comments
Closed

Add non-preempting option to PriorityClasses #902

vllry opened this issue Mar 18, 2019 · 82 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@vllry
Copy link
Contributor

vllry commented Mar 18, 2019

Enhancement Description

PR: kubernetes/kubernetes#74614

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 18, 2019
@vllry
Copy link
Contributor Author

vllry commented Mar 18, 2019

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 18, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

@vllry I'm going to add this to the 1.15 milestone for tracking purposes. Please link to any k/k PRs so we can see the status of the merges to make sure this will make it to code freeze.

/milestone v1.15
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 11, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 14, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @denkensk

@daminisatya
Copy link
Member

daminisatya commented May 18, 2019

Hey, @denkensk @vllry Is alpha release of this enhancement targeted for v1.15?

@vllry
Copy link
Contributor Author

vllry commented May 20, 2019

@daminisatya it is, but I believe API review is still pending.

@daminisatya
Copy link
Member

daminisatya commented May 27, 2019

Thank you @vllry

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

@vllry
Copy link
Contributor Author

vllry commented May 28, 2019

@denkensk do you have time to start docs, or would you like me to start?

@denkensk
Copy link
Member

denkensk commented May 28, 2019

@denkensk do you have time to start docs, or would you like me to start?

@vllry Thank you. You can help to start docs If you have time.

@vllry
Copy link
Contributor Author

vllry commented May 29, 2019

Placeholder docs PR is up: kubernetes/website#14599

@daminisatya what's the deadline for merging the documentation?

@makoscafee
Copy link
Member

makoscafee commented May 29, 2019

Hi, @vllry documentation should be merged by 10th June. but the deadline is broken down to

  • 30th deadline for placeholder PR
  • 04th deadline for all placeholder to have reviewable content
  • 10th all docs PR should be merged.

Thanks.

@mrbobbytables
Copy link
Member

mrbobbytables commented May 30, 2019

@vllry @denkensk, today is code freeze for the 1.15 release cycle. The k/k PRs have not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet.

Is there a high confidence these will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@kacole2
Copy link
Member

kacole2 commented May 31, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 31, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 31, 2019
@vllry
Copy link
Contributor Author

vllry commented May 31, 2019

@kacole2 why was this removed from 1.15? The PR was merged last night.

@kacole2
Copy link
Member

kacole2 commented May 31, 2019

@vllry I apologize about that! I didn't see the PR listed in the original post. adding it back!

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 31, 2019
@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 31, 2019
@vllry
Copy link
Contributor Author

vllry commented May 31, 2019

Sorry about the lack of clarity! Doc PR is open and being refined, let me know if anything is missing.

@denkensk
Copy link
Member

denkensk commented Jun 1, 2019

I apologize about that! I didn't see the PR listed in the original post. adding it back!

I reference this merged pr here kubernetes/kubernetes#74614 thank you

@ahg-g
Copy link
Member

ahg-g commented Oct 25, 2021

/remove-lifecycle stale

@ahg-g
Copy link
Member

ahg-g commented Jan 26, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 26, 2022
@Priyankasaggu11929 Priyankasaggu11929 added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 27, 2022

Hello @denkensk 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage stable for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@denkensk
Copy link
Member

denkensk commented Feb 14, 2022

GA Progress Record:

All pr for GA have been merged.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 15, 2022

Hello @denkensk 👋

With 1.24 Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, I'm just checking in once more.

With all the required KEP PRs merged into k/enhancements & k/website, this enhancement is all good for the upcoming 1.24 code freeze. 🚀 For note, the status of this enhancement is marked as tracked.

Kindly please let me know if I'm missing any PRs other than the ones I linked above.

Also please link all the milestone PRs in the above issue description (for tracking purposes). Thank you so much!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @denkensk, could you please confirm is the following PR is part of the GA implementation for the enhancement? Thanks!

@denkensk
Copy link
Member

denkensk commented Mar 18, 2022

Hello @denkensk, could you please confirm is the following PR is part of the GA implementation for the enhancement? Thanks!

Hi @Priyankasaggu11929 It's not the necessary part of GA.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Thanks so much for the prompt confirmation, @denkensk!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 9, 2022

Hello @denkensk 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 7, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2022
@ahg-g
Copy link
Member

ahg-g commented Aug 7, 2022

Graduated to GA

@ahg-g ahg-g closed this as completed Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests