Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Watch Bookmarks support #956

Closed
wojtek-t opened this issue Apr 12, 2019 · 31 comments · Fixed by #1401
Closed

Add Watch Bookmarks support #956

wojtek-t opened this issue Apr 12, 2019 · 31 comments · Fixed by #1401
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@wojtek-t
Copy link
Member

wojtek-t commented Apr 12, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add support for watch bookmarks to reduce load on kube-apiserver
  • Kubernetes Enhancement Proposal: KEP: watch bookmarks
  • Primary contact (assignee): wojtek-t
  • Responsible SIGs: sig-apimachinery, sig-scalability
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.15)
    • Beta release target (1.16)
    • Stable release target (1.17)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@wojtek-t wojtek-t self-assigned this Apr 12, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 12, 2019

@wojtek-t: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <group-name>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 12, 2019
@wojtek-t wojtek-t added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 12, 2019
@wojtek-t wojtek-t added this to the v1.15 milestone Apr 12, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

Thanks @wojtek-t. When coding begins please drop all k/k PRs here for tracking purposes.

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 12, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 14, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Apr 26, 2019

Ref kubernetes/kubernetes#73585

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 29, 2019

@wojtek-t we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing a test plan which is required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019.

@wojtek-t
Copy link
Member Author

wojtek-t commented Apr 30, 2019

#1021 is out for review

@wojtek-t
Copy link
Member Author

wojtek-t commented Apr 30, 2019

@mrbobbytables - merged.

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 30, 2019

Awesome. Thanks!

@christianh814
Copy link

christianh814 commented May 13, 2019

Hey @wojtek-t I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@wojtek-t
Copy link
Member Author

wojtek-t commented May 17, 2019

@christianh814 Doc PR has been opened: kubernetes/website#14379

@wojtek-t
Copy link
Member Author

wojtek-t commented May 20, 2019

@christianh814 - Doc PR has been merged.

@wojtek-t
Copy link
Member Author

wojtek-t commented Jun 28, 2019

I would like to move it to Beta in 1.16. I already sent out a minor update to testing plan for Beta and will be pushing that in the meantime.

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 28, 2019
@wojtek-t wojtek-t modified the milestones: v1.15, v1.16 Jun 28, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Jul 10, 2019

Hey there @wojtek-t, I'm one of the 1.16 Enhancement Shadows. It looks like you're ahead of the game with flagging as beta / linking to k/k PR :)

Just as a general reminder:
Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

@wojtek-t wojtek-t added this to the v1.16 milestone Sep 12, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 22, 2019

Hey there @wojtek-t -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Sep 22, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 22, 2019
@wojtek-t wojtek-t added this to the v1.17 milestone Sep 23, 2019
@wojtek-t wojtek-t added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 23, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Sep 23, 2019

Yes - I would like to promote it to GA in 1.17.

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 23, 2019

Great, thank you! I'll update the tracking sheet 👍

Sort of an unrelated FYI -- the Enhancements team should be the only ones adding/removing the tracked/* labels. 😬 It's used as an ack that the info has or should not be added to the tracking sheet.

tracked/yes: the Enhancements team has discussed with the owner and added the issue to the Enhancements tracking spreadsheet
tracked/no: the Enhancements team has discussed with the owner and the enhancement will not be graduating for the cycle in question

@wojtek-t
Copy link
Member Author

wojtek-t commented Sep 23, 2019

@mrbobbytables - I see. Will keep that in mind for the future.

@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 18, 2019

Code is merged. Docs PR is opened. Once merged, it will be fully done.

@pgburt
Copy link

pgburt commented Oct 22, 2019

Hello @wojtek-t , I'm one of the v1.17 docs shadows.
I see you've already linked docs, so I've updated the 1.17 Enhancement Tracker Sheet with that info.

This is just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 22, 2019

@pgburt - kubernetes/website#17026 is already out for review for a couple days

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 5, 2019

All PRs, including docs, are merged. This is completely done.

@annajung
Copy link
Member

annajung commented Nov 6, 2019

Hey @wojtek-t 1.17 Enhancement Shadow here! 👋
The Enhancement team needs to track of all k/k PRs related to this enhancement and I was wondering if there were any other k/k PRs that need to be added to our tracking sheet other than kubernetes/kubernetes#83195?

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 6, 2019

See the comment above - everything is merged.

@warmchang
Copy link

warmchang commented Nov 6, 2019

See the comment above - everything is merged.

But this issue is still open 😄 , can it be closed?

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 6, 2019

Do we close enhancements issues immediately after all PRs are merged?
I had a feeling that we close them once the release containing the feature is out.

@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 6, 2019

I had a feeling that we close them once the release containing the feature is out.

Yup 👍 This is in case something has to be backed out at the last minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.