Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Update huge pages KEP for NUMA support of huge pages #1245

Closed
wants to merge 2 commits into from

Conversation

bg-chun
Copy link
Member

@bg-chun bg-chun commented Sep 18, 2019

Propose new enhancement for hugepage.

Signed-off-by: Byonggon Chun bg.chun@samsung.com

Signed-off-by: Byonggon Chun <bg.chun@samsung.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bg-chun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bg-chun
To complete the pull request process, please assign dchen1107
You can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 18, 2019
@odinuge
Copy link
Member

odinuge commented Sep 18, 2019

/ok-to-test
/cc

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2019
Signed-off-by: Byonggon Chun <bg.chun@samsung.com>
@bg-chun
Copy link
Member Author

bg-chun commented Sep 18, 2019

/cc ConnorDoyle

@bg-chun
Copy link
Member Author

bg-chun commented Sep 19, 2019

Regarding NUMA, my plan is supporting NUMA by cpuset.mems and MemoryManager.
So in this PR, it proposes only cAdvisor changes to discover pre-allocated huge pages.

@klueska klueska mentioned this pull request Sep 26, 2019
11 tasks
@bg-chun bg-chun changed the title Update huge pages KEP for NUMA support of huge pages [WIP]Update huge pages KEP for NUMA support of huge pages Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2019
@bg-chun bg-chun closed this Nov 13, 2019
@bg-chun
Copy link
Member Author

bg-chun commented Dec 2, 2019

I closed issue, cAdvisor was updated without updating hugepages KEP.
check out https://github.com/google/cadvisor/commits?author=ohsewon&since=2019-09-30&until=2019-10-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants