Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dual-stack phase 3 details #1280

Merged
merged 4 commits into from
Oct 14, 2019
Merged

Add dual-stack phase 3 details #1280

merged 4 commits into from
Oct 14, 2019

Conversation

lachie83
Copy link
Member

@lachie83 lachie83 commented Oct 4, 2019

This PR updates the dual-stack KEP to include phase 3 works and amends the content to match the phase 1 and 2 implementation.

Complete changes list

  • Consistent on dual-stack
  • Update last-updated
  • Add Services proposal
  • Update Endpoint proposal
  • Remove extra Graduation Criteria section
  • Update CoreDNS non-goal
  • Update proposal to match phase 1 & 2 implementation
  • Update phase 1 & 2 k8s release
  • Add phase 3
  • Update kubectl get pods outputs
  • Update kubectl describe pod output
  • Update Downward API implementation details
  • Update e2e tests based on phase 2 implementations
  • Update container runtime verbiage

/sig network

Signed-off-by: Lachlan Evenson lachlan.evenson@microsoft.com

@lachie83
Consistent on dual-stack
1301a7a 
Update last-updated
Add Services proposal
Update Endpoint proposal
Remove extra Graduation Criteria section
Update CoreDNS non-goal
Update proposal to match phase 1 & 2 implementation
Update phase 1 & 2 k8s release
Add phase 3
Update kubectl get pods outputs
Update kubectl describe pod output
Update Downward API implementation details
Update e2e tests based on phase 2 implementations
Updare container runtime verbiage

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2019
@lachie83 lachie83 mentioned this pull request Oct 4, 2019
Closed
@aojea
Copy link
Member

aojea commented Oct 4, 2019

/cc

@lachie83
Fix typo based on review
36c8a24 
remove incorrect endointFamily references

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
@aojea
Copy link
Member

aojea commented Oct 7, 2019

@thockin @khenidak do you think that it should be discussed here the node.Status.Addresses topic?

If there are is no external cloud-provider the kubelet keeps overriding the internalIP addresses https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/nodestatus/setters.go#L204-L207
that makes impossible to add new ones, causing kubernetes/kubernetes#42125

I was trying to understand better the behaviour but seems that these fields have some history kubernetes/kubernetes#79391 .

Also, @uablrek commented that has a dependency on the IP's returned for PODs with hostNetwork: true

Please note that this is related to the IP's returned for PODs with hostNetwork: true. They shall basically be the same, or maybe a subset? I think these addresses must be configured for all CRI-plugins, unless kubelet sets them.

aojea
aojea reviewed Oct 7, 2019
View reviewed changes
keps/sig-network/20180612-ipv4-ipv6-dual-stack.md Outdated
@@ -613,9 +522,9 @@ Kubeadm will also need to generate dual-stack CIDRs for the --cluster-cidr argum
This dual-stack proposal will introduce a new IPNetSlice object to spf13.pflag to allow parsing of comma separated CIDRs. Refer to [https://github.com/spf13/pflag/pull/170](https://github.com/spf13/pflag/pull/170)

### End-to-End Test Support
End-to-End tests will be updated for Dual Stack. The Dual Stack E2E tests will use deployment scripts from the kubernetes-sigs/kubeadm-dind-cluster github repo to set up a containerized, multi-node Kubernetes cluster that is running in a Prow container (Docker-in-Docker-in-Docker, or DinDinD configuration), similar to the IPv6-only E2E tests (see [test-infra PR # 7529](https://github.com/kubernetes/test-infra/pull/7529)). The DinDinD cluster will be updated to support dual-stack.
End-to-End tests will be updated for dual-stack. The dual-stack E2E tests will use deployment scripts from the kubernetes-sigs/kubeadm-dind-cluster github repo to set up a containerized, multi-node Kubernetes cluster that is running in a Prow container (Docker-in-Docker-in-Docker, or DinDinD configuration), similar to the IPv6-only E2E tests (see [test-infra PR # 7529](https://github.com/kubernetes/test-infra/pull/7529)). The DinDinD cluster will be updated to support dual-stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are going to use kubernetes-sigs/kind instead of kubernetes-sigs/kubeadm-dind-cluster , we should update it here.
We show replace (see [test-infra PR # 7529](https://github.com/kubernetes/test-infra/pull/7529)) by https://testgrid.k8s.io/sig-release-master-blocking#kind-ipv6-master-parallel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to reflect testing situation. PTAL

@lachie83
update e2e test infra
051ce52 
Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
@lachie83
Update implementation history
1d4650f 
Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
@sftim
Copy link
Contributor

sftim commented Oct 13, 2019

Which phase is kubernetes/dns#315 (“support for AAAA records in DNS specification”) in-scope for?

thockin
thockin reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lachie83, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3c37589 into kubernetes:master Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 14, 2019
@lachie83
Copy link
Member Author

Which phase is kubernetes/dns#315 (“support for AAAA records in DNS specification”) in-scope for?

This KEP is to track the core API changes for dualstack. External dependencies are not explicitly tracked however we are validating some of the external dependencies for testing purposes. Presumably this change can be implemented once the core APIs support dualstack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@dcbw dcbw dcbw left review comments

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
6 participants
@lachie83 @aojea @sftim @k8s-ci-robot @thockin @dcbw