Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP to graduate NodeLocal DNSCache to GA. #1307

Closed
wants to merge 1 commit into from
Closed

KEP to graduate NodeLocal DNSCache to GA. #1307

wants to merge 1 commit into from

Conversation

prameshj
Copy link
Contributor

Issue tracking this - #1024

/assign @bowei @thockin @johnbelamaric

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prameshj
To complete the pull request process, please assign dcbw
You can assign the PR to them by writing /assign @dcbw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 14, 2019
wojtek-t
wojtek-t reviewed Oct 14, 2019
View reviewed changes
keps/sig-network/20191014-nodelocaldns-GA-proposal.md
@@ -0,0 +1,103 @@
---
title: NodeLocal DNSCache GA Proposal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should create a separate KEP for GA-ing the feature.
We should reflect the thoughts we have in the existing nodelocal-cache-dns KEP:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0030-nodelocal-dns-cache.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense -- pavithra, maybe amend that doc instead?

@johnbelamaric
Copy link
Member

@prameshj please amend previous KEP as described above.

/close

@k8s-ci-robot
Copy link
Contributor

@johnbelamaric: Closed this PR.

In response to this:

@prameshj please amend previous KEP as described above.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prameshj prameshj mentioned this pull request Nov 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

@thockin thockin

@johnbelamaric johnbelamaric

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@prameshj @k8s-ci-robot @johnbelamaric @bowei @wojtek-t @thockin