Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in node label for Topology Manager #1340

Closed

Conversation

bg-chun
Copy link
Member

@bg-chun bg-chun commented Oct 28, 2019

Purpose of this PR

Propose new built-in label beta.kubernetes.io/topology for topology-aware pod scheduling.
Topology Manager offers various policies for topology-aware resource allocation.
However, there is no built-in way to schedule pod to the particular node that has Topology Policy which Pod wants at this moment.

Milestone

1.17(the date of code freeze for 1.18 is Nov, 14) or 1.18 rel

Appendix

nodeSelector and label provides a very simple way to constrain pods to nodes with particular labels such as kubernetes.io/arch, kubernetes.io/os, kubernetes.io/hostname.
Those are pretty helpful to deploy the pod which has a special requirement and build/manage a cluster.

Signed-off-by: Byonggon Chun bg.chun@samsung.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bg-chun
To complete the pull request process, please assign derekwaynecarr
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 28, 2019
@bg-chun
Copy link
Member Author

bg-chun commented Oct 28, 2019

/cc @klueska @ConnorDoyle

@bg-chun bg-chun mentioned this pull request Oct 28, 2019
11 tasks
Signed-off-by: Byonggon Chun <bg.chun@samsung.com>
@bg-chun bg-chun force-pushed the add_label_for_topology_policy branch from bcc3daf to 3d112c6 Compare October 28, 2019 13:11
@lmdaly
Copy link
Contributor

lmdaly commented Nov 6, 2019

I actually think this is a useful feature to have. Though I would have a suggestion that the node label should not just be topology but topology-management-policy to be explicit.

Not sure if this is something that is generally done, for example there are no other kubelet flags exposed as labels such as the cpu manager policy. So it might need a wider set of discussions, but in general I like the idea.

@kad
Copy link
Member

kad commented Jun 18, 2020

@bg-chun let's re-open this proposal, and see what kind of labeling we will be able to do.
Especially with good use cases on how it can be used for real workloads.

@KunWuLuan
Copy link

/cc

@k8s-ci-robot
Copy link
Contributor

@KunWuLuan: GitHub didn't allow me to request PR reviews from the following users: KunWuLuan.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants