New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built-in node label for Topology Manager #1340
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bg-chun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @klueska @ConnorDoyle |
Signed-off-by: Byonggon Chun <bg.chun@samsung.com>
bcc3daf
to
3d112c6
Compare
I actually think this is a useful feature to have. Though I would have a suggestion that the node label should not just be topology but topology-management-policy to be explicit. Not sure if this is something that is generally done, for example there are no other kubelet flags exposed as labels such as the cpu manager policy. So it might need a wider set of discussions, but in general I like the idea. |
@bg-chun let's re-open this proposal, and see what kind of labeling we will be able to do. |
/cc |
@KunWuLuan: GitHub didn't allow me to request PR reviews from the following users: KunWuLuan. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Purpose of this PR
Propose new built-in label
beta.kubernetes.io/topology
for topology-aware pod scheduling.Topology Manager offers various policies for topology-aware resource allocation.
However, there is no built-in way to schedule pod to the particular node that has Topology Policy which Pod wants at this moment.
Milestone
1.17(the date of code freeze for 1.18 is Nov, 14) or 1.18 rel
Appendix
nodeSelector
andlabel
provides a very simple way to constrain pods to nodes with particular labels such askubernetes.io/arch
,kubernetes.io/os
,kubernetes.io/hostname
.Those are pretty helpful to deploy the pod which has a special requirement and build/manage a cluster.
Signed-off-by: Byonggon Chun bg.chun@samsung.com