Update Server-Side Apply KEP with upgrade strategy from client-side apply

[julianvmodesto]

This change updates the server-side apply KEP with the strategy for upgrading client-side kubectl apply's last-applied-configuration annotation to server-side apply, as originally provided by @jennybuckley in Upgrade pathway: Client Side Apply to Server Side Apply.

WIP here: kubernetes/kubernetes#84134

Umbrella: kubernetes/kubernetes#73723

/wg apply

[k8s-ci-robot]

Welcome @julianvmodesto!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @julianvmodesto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[apelisse]

cc @lavalamp

[lavalamp]

this implies that when we turn SSA on for everything, we'll actually check for the presence of the annotation and not do the update logic if it is found (or at least not store the result)?

[julianvmodesto]

Oh no, I'll fix this. We do want to proceed with and store the update logic after reading and converting the annotation.

[julianvmodesto]

I'll copy an example from Jenny's doc to better illustrate what will happen here.

[julianvmodesto]

I'll update this to match the current changes in kubernetes/kubernetes#84134 and kubernetes/kubernetes#90187

[julianvmodesto]

Updated to match the changes in kubernetes/kubernetes#90187

[julianvmodesto]

/wg api-expression
/sig cli

[apelisse]

/lgtm
/assign @lavalamp

[lavalamp]

Just one minor comment.

[lavalamp]

It's not clear that this is a problem we seek to avoid, I'd reword to add something like "If we don't specifically handle this case, then".

[lavalamp]

/lgtm
/approve

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julianvmodesto, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/sig-api-machinery/OWNERS [lavalamp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment