Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port serviceaccount token volume design proposal to KEP #1594

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

zshihang
Copy link
Contributor

@zshihang zshihang commented Mar 4, 2020

this PR is a copy of the pre-existing design proposal kubernetes/community#1973 and we would like to convert the design proposal into this KEP and iterate on it. more changes can be expected in subsequent PRs to this KEP with the goal of GA this feature which provides nice security properties.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @zshihang!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @zshihang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2020
@zshihang
Copy link
Contributor Author

zshihang commented Mar 4, 2020

/cc mikedanese

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 4, 2020
@mikedanese mikedanese self-assigned this Mar 6, 2020
@mikedanese
Copy link
Member

mikedanese commented Mar 6, 2020

@mikedanese
Copy link
Member

/lgtm
/cc @liggitt @smarterclayton
/assgin @jsafrane @saad-ali

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@liggitt
Copy link
Member

liggitt commented Mar 9, 2020

lgtm as a port of the original design, would recommend adding the original reviewers/approvers to the doc

would like to merge this as-is (since it's a move of a historical document), then iterate on the migration plan

@zshihang zshihang force-pushed the master branch 2 times, most recently from 89bc2c9 to 85835c0 Compare March 9, 2020 17:01
@zshihang
Copy link
Contributor Author

zshihang commented Mar 9, 2020

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@zshihang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikedanese mikedanese added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 9, 2020
on top of this, i'll add the proposal for file permission handling
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2020
@saad-ali
Copy link
Member

saad-ali commented Mar 9, 2020

Thanks for the clarification. No objections to porting design doc to KEP and iterating on it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@saad-ali
Copy link
Member

saad-ali commented Mar 9, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, saad-ali, zshihang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6acd3e1 into kubernetes:master Mar 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants