Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set out-of-tree-vsphere KEP to implemented #1675

Closed
wants to merge 1 commit into from
Closed

Set out-of-tree-vsphere KEP to implemented #1675

wants to merge 1 commit into from

Conversation

frapposelli
Copy link
Member

Fixes: #670

/assign @andrewsykim

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Apr 9, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 9, 2020
@frapposelli
Copy link
Member Author

/cc @cheftako

@frapposelli
Copy link
Member Author

/cc @palnabarun @johnbelamaric

palnabarun
palnabarun requested changes Apr 9, 2020
View reviewed changes
keps/sig-cloud-provider/20190125-out-of-tree-vsphere.md
@@ -17,7 +17,7 @@ approvers:
editor: TBD
creation-date: 2019-01-25
last-updated: 2019-01-25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please update the last-updated date?

andrewsykim
andrewsykim reviewed Apr 9, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

LGTM after last-updated is updated.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, frapposelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@frapposelli frapposelli mentioned this pull request Apr 9, 2020
Merged
@frapposelli
Copy link
Member Author

superseded by #1677

@frapposelli frapposelli closed this Apr 9, 2020
@justaugustus justaugustus deleted the frapposelli-patch-1 branch April 9, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@palnabarun palnabarun palnabarun requested changes

@cheftako cheftako Awaiting requested review from cheftako

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Out-of-Tree vSphere Cloud Provider
4 participants
@frapposelli @k8s-ci-robot @palnabarun @andrewsykim