Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seccomp KEP as implemented #1932

Merged
merged 1 commit into from Sep 23, 2020
Merged

Update seccomp KEP as implemented #1932

merged 1 commit into from Sep 23, 2020

Conversation

saschagrunert
Copy link
Member

The implementation is done for v1.19.0 and we now can mark this KEP as
implemented.

/cc @tallclair @pjbgf @hasheddan

@saschagrunert
Update seccomp KEP as implemented
29f6272 
The implementation is done for v1.19.0 and we now can mark this KEP as
`implemented`.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 12, 2020
@saschagrunert saschagrunert mentioned this pull request Aug 12, 2020
Open
22 tasks
hasheddan
hasheddan approved these changes Aug 12, 2020
View reviewed changes
Copy link

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
pjbgf
pjbgf approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert
Copy link
Member Author

@kubernetes/sig-node-feature-requests @kubernetes/sig-node-pr-reviews PTAL

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2020
@kikisdeliveryservice
Copy link
Member

Hi @kubernetes/sig-node-pr-reviews ,

Enhancements Lead here. As this KEP was GA in 1.19, can you please approve this PR marking the KEP as implemented so that we can clear out the 1.19 milestone?

Thanks,
Kirsten

@kikisdeliveryservice
Copy link
Member

/assign @dchen1107
/assign @derekwaynecarr

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9dcb6d3 into kubernetes:master Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 23, 2020
@saschagrunert saschagrunert deleted the seccomp branch September 23, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

@hasheddan hasheddan hasheddan approved these changes

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@pjbgf pjbgf

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@saschagrunert @kikisdeliveryservice @derekwaynecarr @k8s-ci-robot @pjbgf @hasheddan @dchen1107