Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1672: add alpha graduation criteria #2065

Merged
merged 2 commits into from Oct 6, 2020
Merged

KEP-1672: add alpha graduation criteria #2065

merged 2 commits into from Oct 6, 2020

Conversation

andrewsykim
Copy link
Member

Add alpha graduation criteria for EndpointSlice API tracking terminating condition.

Signed-off-by: Andrew Sy Kim kim.andrewsy@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 3, 2020
@andrewsykim andrewsykim mentioned this pull request Oct 3, 2020
Closed
andrewsykim
andrewsykim commented Oct 5, 2020
View reviewed changes
Copy link
Member Author

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @thockin @robscott

robscott
robscott reviewed Oct 5, 2020
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! If you haven't already, do you mind adding some notes about the risks involved in this KEP and how we'll need to cautiously roll this out? (Basically just a summary of our earlier discussion).

keps/sig-network/1672-tracking-terminating-endpoints/README.md

* EndpointSlice API includes `Terminating` condition.
* `Terminating` condition can only be set if feature gate `EndpointSliceTerminatingCondition` is enabled.
* Unit tests in endpointslice controller and API validation/strategy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a bit more detail here around what these would cover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is covered under the "Test Plan" section https://github.com/kubernetes/enhancements/blob/0af741e352e8f498a8aeda0fa423b66ca09de836/keps/sig-network/1672-tracking-terminating-endpoints/README.md#test-plan

I admit though that what's written in the KEP today is off from the tests I ended up writing in kubernetes/kubernetes#92968, will update that now

@andrewsykim
Copy link
Member Author

Thanks for the work on this! If you haven't already, do you mind adding some notes about the risks involved in this KEP and how we'll need to cautiously roll this out? (Basically just a summary of our earlier discussion).

I was planning on a larger update around this for the Beta graduation crtieria, which I was planning to write in the v1.21 cycle in case there were any other gotchas we might discover. I don't think anything we discussed is going to impact the initial Alpha stage since it would be off by default. Would it be acceptable to address that in a follow-up PR given the v1.20 deadline for KEPs is tomorrow?

@robscott
Copy link
Member

robscott commented Oct 5, 2020

👍 That's reasonable, just trying to make sure we don't forget about it.

@andrewsykim
KEP-1672: add alpha graduation criteria
d670b0d 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim
KEP-1672: add more details in test plan
d41d34c 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2020
@robscott
Copy link
Member

robscott commented Oct 6, 2020

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
thockin
thockin reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but we'll need to resolve kubernetes/kubernetes#92968 (comment)

@thockin
Copy link
Member

thockin commented Oct 6, 2020

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit a612822 into kubernetes:master Oct 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 6, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Oct 6, 2020 •
edited

Thanks Tim, I'll make sure to update the KEP for beta around that topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@thockin thockin thockin left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

Assignees

@robscott robscott

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewsykim @robscott @thockin @k8s-ci-robot