Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2436 PRR: Controller Manager Leader Migration to alpha #2477

Merged
merged 4 commits into from
Feb 9, 2021

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented Feb 9, 2021

This PR update KEP #2436 as a new feature going alpha in 1.21 milestone.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2021
@jiahuif jiahuif changed the title PRR: Controller Manager Leader Migration to alpha [WIP] PRR: Controller Manager Leader Migration to alpha Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2021
@jiahuif jiahuif changed the title [WIP] PRR: Controller Manager Leader Migration to alpha [WIP] KEP-2436 PRR: Controller Manager Leader Migration to alpha Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2021
@jiahuif jiahuif force-pushed the leader-migration-to-alpha branch 2 times, most recently from 9a48ec6 to 840de97 Compare February 9, 2021 20:57
@jiahuif jiahuif changed the title [WIP] KEP-2436 PRR: Controller Manager Leader Migration to alpha KEP-2436 PRR: Controller Manager Leader Migration to alpha Feb 9, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2021
@jiahuif
Copy link
Member Author

jiahuif commented Feb 9, 2021

/assign @deads2k
For production readiness review of nothing to alpha stage

@deads2k
Copy link
Contributor

deads2k commented Feb 9, 2021

PRR looks good for alpha. thanks.

/approve

@jiahuif
Copy link
Member Author

jiahuif commented Feb 9, 2021

Thank you for PRR.

/assign @cheftako

for sig-cloudprovider

@k8s-ci-robot
Copy link
Contributor

@jiahuif: GitHub didn't allow me to assign the following users: for, sig-cloudprovider.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Thank you for PRR.

/assign @cheftako for sig-cloudprovider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheftako
Copy link
Member

cheftako commented Feb 9, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, deads2k, jiahuif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9802347 into kubernetes:master Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 9, 2021
@jiahuif jiahuif deleted the leader-migration-to-alpha branch February 9, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants