Leader Migration for Controller Managers

[jiahuif]

Enhancement Description

• One-line enhancement description (can be used as a release note): kube-controller-manager and cloud-controller-manager can apply new controller-to-controller-manager assignment in HA control plane without downtime.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/2436-controller-manager-leader-migration
• Discussion Link:
  • cloud controller manager migration: default values and lease types update. #2083
  • (sig-cloudprovider agenda) https://docs.google.com/document/d/1KLsGGzNXQbsPeELCeF_q-f0h0CEGSe20xiwvcR2NlYM/
• Primary contact (assignee): @jiahuif
• Responsible SIGs: CloudProvider
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.21
  • Beta release target (x.y): 1.22
  • Stable release target (x.y): 1.24
• Alpha
  • KEP (k/enhancements) update PR(s):
    • cloud controller manager migration: default values and lease types update. #2083
    • PRR KEP-2436 PRR: Controller Manager Leader Migration to alpha #2477
    • (KEP-2436) fix errors in sample configuration and formatting. #2548
  • Code (k/k) update PR(s):
    • leader migration configuration: parsing & validation. kubernetes#96226
    • register scheme for controller-manager kubernetes#96133
    • add configuration for controller migration. kubernetes#94205
    • Leader Migration (KEP-2477): options parsing kubernetes#99507
    • (KEP-2436) implementation of leader migration for controller manager. kubernetes#96541
  • Docs (k/website) update PR(s):
    • (KEP-2436) Task: Controller Manager Leader Migration website#26970
• Beta
  • KEP (k/enhancements) update PR(s):
    • PRR PRR: KEP-2436 Leader Migration for Controller Managers to beta #2687
    • KEP-2436: wildcard and default value #2731
  • Code (k/k) update PR(s):
    • Leader Migration: wildcard and default value kubernetes#102711
    • KEP-2436 Leader Migration: to beta kubernetes#103533
  • Docs (k/website) update(s):
    • KEP-2436 Leader Migration: to beta website#28882
• Stable
  • KEP (k/enhancements) update PR(s): KEP-2436 Leader Migration to GA #3183
  • Code (k/k) update PR(s): Graduate Leader Migration to GA kubernetes#109072 v1 types for Leader Migration kubernetes#108016
  • Docs (k/website) update(s): Leader Migration to GA website#32052

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[jiahuif]

/sig cloud-provider
/assign
/cc @cheftako @andrewsykim @nckturner
replaces #991

[annajung]

Hi @jiahuif 1.21 Enhancements Lead here, could you clarify which stage this enhancement is graduating to?

Also, is there an open PR to update the current KEP? At the current state, it's at risk of being removed from the milestone for not meeting the PRR requirements.

kep.yaml and KEP template needs to be updated to the latest and it must have PRR approval.

I also noticed this issue replaced #991, in the same PR, could you also rename the KEP to match the new issue number #2436?

Also, enhancements freeze is in effect EOD today, Feb 9th.
Please make sure all requirements are met before then.

Thank you!

[jiahuif]

• clarify which stage this enhancement is graduating to: alpha
  • update in KEP
• PRR PR.
• update kep.yaml and KEP to latest template
• PRR approval
• rename KEP

[jiahuif]

/cc @cheftako @jpbetz @andrewsykim @nckturner @leilajal

[jiahuif]

Status for being "tracked", targeting v1.21 as alpha

• Merged in an implementable state
• Have test plans
• Have graduation criteria
• Have an open issue in the release milestone
• Have Production Readiness Review (merged as KEP-2436 PRR: Controller Manager Leader Migration to alpha #2477 )

[annajung]

With PR #2477 merged, this enhancement meets all the criteria for the Enhancements freeze 👍

[jrsapi]

Greetings @jiahuif
1.21 Enhancement shadow checking in. Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

[jrsapi]

Greetings @jiahuif,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST
Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back.
Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST.
Thanks!

[annajung]

Hi @jiahuif, with the following PRs merged, we're marking this as code complete for the release.

• leader migration configuration: parsing & validation. kubernetes#96226
• register scheme for controller-manager kubernetes#96133
• add configuration for controller migration. kubernetes#94205
• Leader Migration (KEP-2477): options parsing kubernetes#99507
• (KEP-2436) implementation of leader migration for controller manager. kubernetes#96541

[jiahuif]

@annajung I believe the implementation for alpha stage is now complete. Thank you for the help along the way.

[Priyankasaggu11929]

Hello @jiahuif, just a quick check-in again, as we approach the 1.24 enhancements freeze.

Please plan to get #3183 merged before enhancements freeze on Thursday, February 3rd at 18:00pm PT.

For note, the current status of the enhancements is at at-risk. Thank you!

[Priyankasaggu11929]

With KEP PR #3183 merged now, this enhancement is ready for the 1.24 enhancements freeze. 🚀

For note, the status is tracked now.

[chrisnegus]

Hi @jiahuif 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[Priyankasaggu11929]

Hello @jiahuif 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Graduate Leader Migration to GA kubernetes#109072
  • v1 types for Leader Migration kubernetes#108016
• Have a documentation placeholder PR open by Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

[katcosgrove]

Hey y'all! We're approaching last call for feature blogs, as the freeze is Wednesday, March 23. If you have something you would like to have represented, please add it to the tracking sheet. If you have questions, please reach out to me!

[gracenng]

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline
Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[jpbetz]

Apologies @gracenng, we had gotten all lgtms and SIG approvals for the remaining two PRs (kubernetes/kubernetes#109072 and kubernetes/kubernetes#108016) but were missing an approval for a vendor change and a pkg/feature change. Those approvals are now granted. I've submitted an exemption request: https://groups.google.com/g/kubernetes-sig-release/c/DLHfVv8MXvE

[jpbetz]

/milestone v1.24
due to approved code freeze exception

[k8s-ci-robot]

@jpbetz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.24
due to approved code freeze exception

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jpbetz]

@gracenng would you set milestone to v1.24 now that the exception has been approved (https://groups.google.com/g/kubernetes-sig-release/c/DLHfVv8MXvE). Thanks!

[Priyankasaggu11929]

Thanks @jpbetz, I'm setting the milestone to 1.24 & have also updated the tracking sheet.

/milestone v1.24

[Priyankasaggu11929]

Hello @jiahuif 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jiahuif]

Mark as implemented.

/remove-lifecycle stale
/close

[k8s-ci-robot]

@jiahuif: Closing this issue.

In response to this:

Mark as implemented.

/remove-lifecycle stale
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pacoxu]

This is planed to remove in v1.26 and the code freeze of v1.26 is coming next week.
Also, a website update is needed.

---

edited:

• remove FG ControllerManagerLeaderMigration kubernetes#113534 to remove it in k/k
• [v1.27] WIP placeholder: document removal of ControllerManagerLeaderMigration feature gate website#37667 to update the website