Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leader Migration for Controller Managers #2436

Closed
11 of 12 tasks
jiahuif opened this issue Feb 5, 2021 · 42 comments · May be fixed by kubernetes/kubernetes#113534
Closed
11 of 12 tasks

Leader Migration for Controller Managers #2436

jiahuif opened this issue Feb 5, 2021 · 42 comments · May be fixed by kubernetes/kubernetes#113534
Assignees
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@jiahuif
Copy link
Member

jiahuif commented Feb 5, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 5, 2021
@jiahuif
Copy link
Member Author

jiahuif commented Feb 5, 2021

/sig cloud-provider
/assign
/cc @cheftako @andrewsykim @nckturner
replaces #991

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2021
@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2021
@annajung
Copy link
Member

annajung commented Feb 9, 2021

Hi @jiahuif 1.21 Enhancements Lead here, could you clarify which stage this enhancement is graduating to?

Also, is there an open PR to update the current KEP? At the current state, it's at risk of being removed from the milestone for not meeting the PRR requirements.

kep.yaml and KEP template needs to be updated to the latest and it must have PRR approval.

I also noticed this issue replaced #991, in the same PR, could you also rename the KEP to match the new issue number #2436?

Also, enhancements freeze is in effect EOD today, Feb 9th.
Please make sure all requirements are met before then.

Thank you!

@jiahuif
Copy link
Member Author

jiahuif commented Feb 9, 2021

  • clarify which stage this enhancement is graduating to: alpha
    • update in KEP
  • PRR PR.
  • update kep.yaml and KEP to latest template
  • PRR approval
  • rename KEP

@annajung annajung added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 9, 2021
@annajung annajung added this to the v1.21 milestone Feb 9, 2021
@jiahuif
Copy link
Member Author

jiahuif commented Feb 9, 2021

@jiahuif
Copy link
Member Author

jiahuif commented Feb 9, 2021

Status for being "tracked", targeting v1.21 as alpha

@annajung
Copy link
Member

annajung commented Feb 9, 2021

With PR #2477 merged, this enhancement meets all the criteria for the Enhancements freeze 👍

@jrsapi
Copy link

jrsapi commented Feb 18, 2021

Greetings @jiahuif
1.21 Enhancement shadow checking in. Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

@jrsapi
Copy link

jrsapi commented Mar 4, 2021

Greetings @jiahuif,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST
Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back.
Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST.
Thanks!

@jiahuif
Copy link
Member Author

jiahuif commented Mar 10, 2021

@annajung I believe the implementation for alpha stage is now complete. Thank you for the help along the way.

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.24 Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 31, 2022

Hello @jiahuif, just a quick check-in again, as we approach the 1.24 enhancements freeze.

Please plan to get #3183 merged before enhancements freeze on Thursday, February 3rd at 18:00pm PT.

For note, the current status of the enhancements is at at-risk. Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Feb 4, 2022

With KEP PR #3183 merged now, this enhancement is ready for the 1.24 enhancements freeze. 🚀

For note, the status is tracked now.

@chrisnegus
Copy link

chrisnegus commented Feb 11, 2022

Hi @jiahuif 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @jiahuif 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

@Priyankasaggu11929 Priyankasaggu11929 removed the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Mar 18, 2022
@katcosgrove
Copy link

katcosgrove commented Mar 21, 2022

Hey y'all! We're approaching last call for feature blogs, as the freeze is Wednesday, March 23. If you have something you would like to have represented, please add it to the tracking sheet. If you have questions, please reach out to me!

@gracenng
Copy link
Member

gracenng commented Mar 30, 2022

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline
Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 30, 2022
@jpbetz
Copy link
Contributor

jpbetz commented Mar 30, 2022

Apologies @gracenng, we had gotten all lgtms and SIG approvals for the remaining two PRs (kubernetes/kubernetes#109072 and kubernetes/kubernetes#108016) but were missing an approval for a vendor change and a pkg/feature change. Those approvals are now granted. I've submitted an exemption request: https://groups.google.com/g/kubernetes-sig-release/c/DLHfVv8MXvE

@jpbetz
Copy link
Contributor

jpbetz commented Mar 31, 2022

/milestone v1.24
due to approved code freeze exception

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 31, 2022

@jpbetz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.24
due to approved code freeze exception

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpbetz
Copy link
Contributor

jpbetz commented Mar 31, 2022

@gracenng would you set milestone to v1.24 now that the exception has been approved (https://groups.google.com/g/kubernetes-sig-release/c/DLHfVv8MXvE). Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Apr 1, 2022

Thanks @jpbetz, I'm setting the milestone to 1.24 & have also updated the tracking sheet.

/milestone v1.24

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 9, 2022

Hello @jiahuif 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 9, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 7, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2022
@jiahuif
Copy link
Member Author

jiahuif commented Aug 8, 2022

Mark as implemented.

/remove-lifecycle stale
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 8, 2022

@jiahuif: Closing this issue.

In response to this:

Mark as implemented.

/remove-lifecycle stale
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@pacoxu
Copy link
Member

pacoxu commented Nov 2, 2022

This is planed to remove in v1.26 and the code freeze of v1.26 is coming next week.
Also, a website update is needed.


edited:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.