Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-563: PRR updates for dual-stack move to stable #2962

Merged
merged 4 commits into from
Sep 9, 2021
Merged

KEP-563: PRR updates for dual-stack move to stable #2962

merged 4 commits into from
Sep 9, 2021

Conversation

bridgetkromhout
Copy link
Member

Per @johnbelamaric in #563 (comment) we need this KEP status to be correctly listed as "implementable" until completely done.

Signed-off-by: Bridget Kromhout bridget@kromhout.org

@bridgetkromhout
KEP status should still be listed as implementable
144bf1f 
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Sep 8, 2021
@bridgetkromhout
Copy link
Member Author

/assign @johnbelamaric

@bridgetkromhout
Adding minor edit to allow for comments
e6bab7e 
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
@johnbelamaric
Copy link
Member

You'll need to add an updated PRR file now in this PR, with me as approver for the stable stage.

Which means you should review the PRR questions in the KEP and make sure they are all answered for the stable stage.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2021
@bridgetkromhout bridgetkromhout changed the title KEP-563: status should still be listed as implementable KEP-563: PRR updates for dual-stack move to stable Sep 8, 2021
@bridgetkromhout
Copy link
Member Author

You'll need to add an updated PRR file now in this PR, with me as approver for the stable stage.
Which means you should review the PRR questions in the KEP and make sure they are all answered for the stable stage.

@johnbelamaric Thanks! You were already listed as the approver; hopefully this shows up correctly now that I've adjusted "implemented" back to "implementable". I made edits to the PRR based on the fact that the dual-stack feature is no longer feature-gated; I look forward to your feedback and edits.

@bridgetkromhout
Clarifying dual-stack PRR for stable release
1651d43 
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2021
@bridgetkromhout
Copy link
Member Author

bridgetkromhout commented Sep 8, 2021 •
edited
Loading

@johnbelamaric I've reviewed https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md#production-readiness-review-questionnaire and I think this KEP has all the needed PRR fields already. I've updated to state the differences with the feature always being available (in stable) instead of being feature-gated (in beta). (edit: Ah - I see getting PRR approver for stable stage: the selected PRR milestone stage is not populated and will correct.)

@bridgetkromhout
Adding correct field for stable review of PRR
fe9d64e 
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
thockin
thockin reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@johnbelamaric
Copy link
Member

/approve

looks good

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bridgetkromhout, johnbelamaric, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit a122c62 into kubernetes:master Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021
@olljanat olljanat mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@thockin thockin

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bridgetkromhout @johnbelamaric @k8s-ci-robot @thockin