Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2149: Rename id.k8s.io --> cluster.clusterset.k8s.io #3508

Merged
merged 1 commit into from
Sep 28, 2022
Merged

KEP-2149: Rename id.k8s.io --> cluster.clusterset.k8s.io #3508

merged 1 commit into from
Sep 28, 2022

Conversation

lauralorenz
Copy link
Contributor

@lauralorenz lauralorenz commented Sep 13, 2022 •
edited
Loading

  • One-line PR description: Rename id.k8s.io cluster.clusterset.k8s.io.
  • Other comments: This rename was based on SIG-MC discussion around comments by API reviewer @thockin. See background notes here and in SIG-MC discussions on 7/12, 7/26 and on the mailing list for brainstorms and for voting but tl;dr since this CRD has a general apiGroup name (about.k8s.io), the ClusterProperty name id.k8s.io might be interpreted by users semantically on its own and used in cases its restrictions per the KEP do not align with

@lauralorenz
Rename id.k8s.io --> cluster.clusterset.k8s.io
3b005bd 
Based on SIG-MC discussion culminating 7/26/2022

Signed-off-by: Laura Lorenz <lauralorenz@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2022
@lauralorenz
Copy link
Contributor Author

/assign @JeremyOT

@JeremyOT
Copy link
Member

/lgtm
/approve

Thanks @lauralorenz !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeremyOT, lauralorenz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8b540a1 into kubernetes:master Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 28, 2022
@chaunceyjiang chaunceyjiang mentioned this pull request Oct 19, 2022
Merged
@lauralorenz lauralorenz mentioned this pull request Nov 9, 2022
Merged
3 tasks
@JeremyOT JeremyOT mentioned this pull request Aug 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@JeremyOT JeremyOT

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@lauralorenz @JeremyOT @k8s-ci-robot