Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2413 Add new PRR question to SeccompDefault KEP #3864

Merged
merged 1 commit into from Feb 9, 2023
Merged

KEP-2413 Add new PRR question to SeccompDefault KEP #3864

merged 1 commit into from Feb 9, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert
Add new PRR question to SeccompDefault KEP
05f81b8 
The question can be answered with "No", but adding it to match formal
aspects.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2023
@saschagrunert saschagrunert mentioned this pull request Feb 9, 2023
Closed
12 tasks
@bart0sh bart0sh added this to Needs Reviewer in SIG Node PR Triage Feb 9, 2023
@harche
Copy link
Contributor

harche commented Feb 9, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
mrunalp
mrunalp approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@marosset marosset changed the title Add new PRR question to SeccompDefault KEP KEP-2413 Add new PRR question to SeccompDefault KEP Feb 9, 2023
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@marosset
Copy link
Contributor

marosset commented Feb 9, 2023

Part of #2413

@k8s-ci-robot k8s-ci-robot merged commit 12b7f9f into kubernetes:master Feb 9, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 9, 2023
@saschagrunert saschagrunert deleted the seccomp-default-question branch February 10, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@dchen1107 dchen1107

@harche harche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @harche @dchen1107 @k8s-ci-robot @marosset @mrunalp