Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update non-graceful node shutdown KEP following to template #3911

Merged
merged 1 commit into from
May 22, 2023
Merged

Update non-graceful node shutdown KEP following to template #3911

merged 1 commit into from
May 22, 2023

Conversation

YuikoTakada
Copy link
Contributor

  • One-line PR description: Update non-graceful node shutdown KEP following to latest template
  • Issue link:
  • Other comments: KEP template has been updated in this commit. Old template has the problem that line-wrap on bold syntax is broken.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2023
@YuikoTakada YuikoTakada force-pushed the cleanup_2268 branch 2 times, most recently from ba3ca6e to c5002b3 Compare March 17, 2023 00:50
@YuikoTakada
Copy link
Contributor Author

You can see the preview here:
https://github.com/YuikoTakada/enhancements/blob/cleanup_2268/keps/sig-storage/2268-non-graceful-shutdown/README.md

thanks.

@YuikoTakada
Copy link
Contributor Author

In order for update non-graceful node shutdown to GA, it's hard to read README.md.
So I need review. Thanks.

xing-yang
xing-yang reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Looks good other than that. Thanks for the PR!

keps/sig-storage/2268-non-graceful-shutdown/README.md Outdated Show resolved Hide resolved
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang, YuikoTakada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5b75598 into kubernetes:master May 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YuikoTakada @xing-yang @k8s-ci-robot