Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3453: MinimizeIPTablesRestore to GA for 1.28 #3972

Merged
merged 1 commit into from May 4, 2023
Merged

KEP-3453: MinimizeIPTablesRestore to GA for 1.28 #3972

merged 1 commit into from May 4, 2023

Conversation

danwinship
Copy link
Contributor

  • One-line PR description: update KEP-3453 to GA
  • Other comments: no changes other than metadata/administrivia

/assign @thockin

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels May 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2023
@danwinship danwinship changed the title KEP-3453: update to GA for 1.28 KEP-3453: MinimizeIPTablesRestore to GA for 1.28 May 1, 2023
@danwinship danwinship mentioned this pull request May 1, 2023
Closed
15 tasks
thockin
thockin reviewed May 1, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 1, 2023
wojtek-t
wojtek-t reviewed May 2, 2023
View reviewed changes
keps/sig-network/3453-minimize-iptables-restore/kep.yaml Outdated Show resolved Hide resolved
keps/sig-network/3453-minimize-iptables-restore/kep.yaml Show resolved Hide resolved
keps/sig-network/3453-minimize-iptables-restore/README.md
@@ -498,7 +498,8 @@ modes.
- 2022-10-04: Initial KEP merged
- 2022-11-01: Code PR merged
- 2022-11-10: Testing PRs merged; 5000Nodes test begins enabling the feature
- 2022-12-08: Kubernetes 1.26 released
- 2022-12-08: Alpha in Kubernetes 1.26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can't comment on particular lines, so commenting here:

L413: Have those metrics been added? If not, can we make it a GA graduation criteria? [and if they were, can you update the text there?]

And that's my only PRR comment - once addressed this LGTM for GA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! I wrote the PR but never submitted it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward for it (happy to review it).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just don't modify the existing ones, append the new ones, there is a lot of tooling depending on them

@wojtek-t wojtek-t self-assigned this May 2, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 2, 2023
@wojtek-t
Copy link
Member

wojtek-t commented May 4, 2023

/lgtm
/approve PRR

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 43dc840 into kubernetes:master May 4, 2023
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@thockin thockin

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danwinship @wojtek-t @k8s-ci-robot @thockin @aojea