Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GA requirement for extending metrics stability #4041

Merged
merged 1 commit into from
Jun 1, 2023
Merged

add GA requirement for extending metrics stability #4041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-instrumentation/3498.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ alpha:
approver: "@wojtek-t"
beta:
approver: "@wojtek-t"
stable:
approver: "@wojtek-t"
1 change: 1 addition & 0 deletions keps/sig-instrumentation/3498-extending-stability/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ For the beta version of this KEP, we begin permitting metrics to be promoted to

- We will allow bake time before promoting this feature to GA
- At this stage, we will promote our meta-metric for registered metrics to Stable
- We also require an update to the prometheus golang client such that we can add process start time to a header, so that scraping clients do not have to parse the entire metrics payload in order to properly process counter metrics. Please see [this PR](https://github.com/prometheus/client_golang/pull/1278) for more details.

#### Deprecation

Expand Down
2 changes: 1 addition & 1 deletion keps/sig-instrumentation/3498-extending-stability/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ latest-milestone: "v1.27"
milestone:
alpha: "v1.26"
beta: "v1.27"
stable: "v1.29"
stable: "v1.28"

feature-gates:
- name: "n/a"
Expand Down