3221: update KEP according to 1.29 requirements #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
sig/auth
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
the
size/M
25 tasks
palnabarun
force-pushed
the
3221/1.29-updates
branch
2 times, most recently
from
c82934e
to
353a696
Compare
liggitt
reviewed
Sep 27, 2023
keps/sig-auth/3221-structured-authorization-configuration/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/3221-structured-authorization-configuration/README.md
Outdated
Show resolved
Hide resolved
ritazh
reviewed
Sep 28, 2023
|
@palnabarun looks like we are missing this. Can you ptal?
|
palnabarun
force-pushed
the
3221/1.29-updates
branch
from
353a696
to
a393ef5
Compare
|
@liggitt -- can you PTAL again? |
I think the Enhancement team mean is that this PR should be merged. From a 1.29 POV, we should actually be good. We are just amending implementation details in this PR. |
liggitt
reviewed
Oct 4, 2023
keps/sig-auth/3221-structured-authorization-configuration/README.md
Outdated
Show resolved
Hide resolved
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, palnabarun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun
force-pushed
the
3221/1.29-updates
branch
from
a393ef5
to
90d1672
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the KEP contents based on what we have been discussing and implementing over the pas month.
/assign @ritazh @liggitt @enj
/sig auth