Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4368: Job API managed-by label #4370

Merged
merged 51 commits into from
Feb 5, 2024
Merged

KEP-4368: Job API managed-by label #4370

merged 51 commits into from
Feb 5, 2024

Commits on Jan 22, 2024

  1. Support batch labels for jobs

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    de64f6a View commit details
    Browse the repository at this point in the history

  2. Review remarks

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9427af4 View commit details
    Browse the repository at this point in the history

  3. Drop the point about multiple conditions

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e422fa3 View commit details
    Browse the repository at this point in the history

  4. Add point about compatibility with CronJob

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    020e804 View commit details
    Browse the repository at this point in the history

  5. Explicit note on mutability

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    3f77bcf View commit details
    Browse the repository at this point in the history

  6. Extend the unit test scenarios

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    3b1b7b7 View commit details
    Browse the repository at this point in the history

  7. Add a note about new version with disabled feature gate

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4a75cba View commit details
    Browse the repository at this point in the history

  8. Add a note on debuggability

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    47cd554 View commit details
    Browse the repository at this point in the history

  9. points added

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8cc4384 View commit details
    Browse the repository at this point in the history

  10. propose the new metric

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c83c634 View commit details
    Browse the repository at this point in the history

  11. update the MultiKueue link

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2346031 View commit details
    Browse the repository at this point in the history

  12. typo

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1ef8ea6 View commit details
    Browse the repository at this point in the history

  13. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Maciej Szulik <soltysh@gmail.com>
    @mimowo @soltysh
    mimowo and soltysh committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    89bcc57 View commit details
    Browse the repository at this point in the history

  14. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Maciej Szulik <soltysh@gmail.com>
    @mimowo @soltysh
    mimowo and soltysh committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    a6abc34 View commit details
    Browse the repository at this point in the history

  15. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Maciej Szulik <soltysh@gmail.com>
    @mimowo @soltysh
    mimowo and soltysh committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    20a83ae View commit details
    Browse the repository at this point in the history

  16. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Maciej Szulik <soltysh@gmail.com>
    @mimowo @soltysh
    mimowo and soltysh committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e1696f8 View commit details
    Browse the repository at this point in the history

  17. add a note about the SLOs

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0683203 View commit details
    Browse the repository at this point in the history

  18. add a note about the downgrade

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    543452f View commit details
    Browse the repository at this point in the history

  19. note about the apiservers

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6cf23d3 View commit details
    Browse the repository at this point in the history

  20. add a note about using the metric to find out the feature is used

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    961dc92 View commit details
    Browse the repository at this point in the history

  21. add tests for the metric

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    44c7f41 View commit details
    Browse the repository at this point in the history

  22. Add validation rules to prevent problems for CronJob

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    025e5bd View commit details
    Browse the repository at this point in the history

  23. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
    @mimowo @alculquicondor
    mimowo and alculquicondor committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4e318a5 View commit details
    Browse the repository at this point in the history

  24. Added the validation rules

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c2e949b View commit details
    Browse the repository at this point in the history

  25. metion the strengtening of the CronJob implementation

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    aeb9050 View commit details
    Browse the repository at this point in the history

  26. cleanup

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c362295 View commit details
    Browse the repository at this point in the history

  27. add note about multiKueue

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    99abcc2 View commit details
    Browse the repository at this point in the history

  28. add a note about coverage for validation package

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0111955 View commit details
    Browse the repository at this point in the history

  29. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Filip Křepinský <fkrepins@redhat.com>
    @mimowo @atiratree
    mimowo and atiratree committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    59dc7ea View commit details
    Browse the repository at this point in the history

  30. add a GA graduation point to look for other implementations 

    and conformance with k8s
    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    81d5bd5 View commit details
    Browse the repository at this point in the history

  31. Status fields for indexes are non-nil only when completionMode: Indexed

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c340dee View commit details
    Browse the repository at this point in the history

  32. clarifications

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    343831f View commit details
    Browse the repository at this point in the history

  33. add to the reasons for rollback section

    @mimowo
    mimowo committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    60d54a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
    @mimowo @alculquicondor
    mimowo and alculquicondor committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7812d34 View commit details
    Browse the repository at this point in the history

  2. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
    @mimowo @alculquicondor
    mimowo and alculquicondor committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0601e29 View commit details
    Browse the repository at this point in the history

  3. Add notes about tests

    @mimowo
    mimowo committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5129ba1 View commit details
    Browse the repository at this point in the history

  4. add a note about risk on rollback

    @mimowo
    mimowo committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0b63bf0 View commit details
    Browse the repository at this point in the history

  5. cleanup the skew version paragraph

    @mimowo
    mimowo committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a0c79e2 View commit details
    Browse the repository at this point in the history

  6. grammar fix

    @mimowo
    mimowo committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2290310 View commit details
    Browse the repository at this point in the history

  7. paragraph cleanup

    @mimowo
    mimowo committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    25fd4ed View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep… 

    ….yaml

Co-authored-by: Tim Bannister <tim@scalefactory.com>
    @mimowo @sftim
    mimowo and sftim committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0d6fa68 View commit details
    Browse the repository at this point in the history

  2. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep… 

    ….yaml

Co-authored-by: Tim Bannister <tim@scalefactory.com>
    @mimowo @sftim
    mimowo and sftim committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    728fb08 View commit details
    Browse the repository at this point in the history

  3. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep… 

    ….yaml

Co-authored-by: Tim Bannister <tim@scalefactory.com>
    @mimowo @sftim
    mimowo and sftim committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    78ad42e View commit details
    Browse the repository at this point in the history

  4. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>
    @mimowo @sftim
    mimowo and sftim committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a7c7ef6 View commit details
    Browse the repository at this point in the history

  5. Change quotes for the managed-by label

    @mimowo
    mimowo committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5f71a5d View commit details
    Browse the repository at this point in the history

  6. mention the full name early in the doc

    @mimowo
    mimowo committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a480243 View commit details
    Browse the repository at this point in the history

  7. Add alternative names section

    @mimowo
    mimowo committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    fe3922b View commit details
    Browse the repository at this point in the history

  8. Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA… 

    …DME.md

Co-authored-by: Maciej Szulik <soltysh@gmail.com>
    @mimowo @soltysh
    mimowo and soltysh committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2ce08dd View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Review remarks about the e2e tests and upgrade testing

    @mimowo
    mimowo committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c0fa810 View commit details
    Browse the repository at this point in the history

  2. add checkpoints

    @mimowo
    mimowo committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    09321d0 View commit details
    Browse the repository at this point in the history

  3. fix the nit

    @mimowo
    mimowo committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    efe5ad0 View commit details
    Browse the repository at this point in the history