Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4368: Job API managed-by label #4370

Merged
merged 51 commits into from
Feb 5, 2024
Merged

KEP-4368: Job API managed-by label #4370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
de64f6a
Support batch labels for jobs
mimowo Dec 20, 2023
9427af4
Review remarks
mimowo Jan 17, 2024
e422fa3
Drop the point about multiple conditions
mimowo Jan 18, 2024
020e804
Add point about compatibility with CronJob
mimowo Jan 18, 2024
3f77bcf
Explicit note on mutability
mimowo Jan 18, 2024
3b1b7b7
Extend the unit test scenarios
mimowo Jan 18, 2024
4a75cba
Add a note about new version with disabled feature gate
mimowo Jan 18, 2024
47cd554
Add a note on debuggability
mimowo Jan 18, 2024
8cc4384
points added
mimowo Jan 19, 2024
c83c634
propose the new metric
mimowo Jan 19, 2024
2346031
update the MultiKueue link
mimowo Jan 19, 2024
1ef8ea6
typo
mimowo Jan 19, 2024
89bcc57
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 19, 2024
a6abc34
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 19, 2024
20a83ae
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 19, 2024
e1696f8
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 19, 2024
0683203
add a note about the SLOs
mimowo Jan 19, 2024
543452f
add a note about the downgrade
mimowo Jan 19, 2024
6cf23d3
note about the apiservers
mimowo Jan 19, 2024
961dc92
add a note about using the metric to find out the feature is used
mimowo Jan 19, 2024
44c7f41
add tests for the metric
mimowo Jan 19, 2024
025e5bd
Add validation rules to prevent problems for CronJob
mimowo Jan 19, 2024
4e318a5
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 19, 2024
c2e949b
Added the validation rules
mimowo Jan 19, 2024
aeb9050
metion the strengtening of the CronJob implementation
mimowo Jan 19, 2024
c362295
cleanup
mimowo Jan 19, 2024
99abcc2
add note about multiKueue
mimowo Jan 19, 2024
0111955
add a note about coverage for validation package
mimowo Jan 22, 2024
59dc7ea
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 22, 2024
81d5bd5
add a GA graduation point to look for other implementations
mimowo Jan 22, 2024
c340dee
Status fields for indexes are non-nil only when completionMode: Indexed
mimowo Jan 22, 2024
343831f
clarifications
mimowo Jan 22, 2024
60d54a2
add to the reasons for rollback section
mimowo Jan 22, 2024
7812d34
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 24, 2024
0601e29
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 24, 2024
5129ba1
Add notes about tests
mimowo Jan 24, 2024
0b63bf0
add a note about risk on rollback
mimowo Jan 24, 2024
a0c79e2
cleanup the skew version paragraph
mimowo Jan 24, 2024
2290310
grammar fix
mimowo Jan 24, 2024
25fd4ed
paragraph cleanup
mimowo Jan 24, 2024
0d6fa68
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep…
mimowo Jan 26, 2024
728fb08
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep…
mimowo Jan 26, 2024
78ad42e
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep…
mimowo Jan 26, 2024
a7c7ef6
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 26, 2024
5f71a5d
Change quotes for the managed-by label
mimowo Jan 26, 2024
a480243
mention the full name early in the doc
mimowo Jan 26, 2024
fe3922b
Add alternative names section
mimowo Jan 26, 2024
2ce08dd
Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/REA…
mimowo Jan 26, 2024
c0fa810
Review remarks about the e2e tests and upgrade testing
mimowo Feb 1, 2024
09321d0
add checkpoints
mimowo Feb 1, 2024
efe5ad0
fix the nit
mimowo Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions keps/prod-readiness/sig-apps/4368.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kep-number: 4368
beta:
approver: "@wojtek-t"