Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3716: graduate to stable for 1.30 #4435

Merged
merged 1 commit into from Jan 31, 2024
Merged

KEP-3716: graduate to stable for 1.30 #4435

merged 1 commit into from Jan 31, 2024

Conversation

ivelichkovich
Copy link
Contributor

  • One-line PR description:

Updates testing/metrics information and stages KEP for GA in 1.30.

  • Other comments:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 23, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ivelichkovich / name: Igor Velichkovich (135106b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2024
ivelichkovich
ivelichkovich commented Jan 23, 2024
View reviewed changes
keps/sig-api-machinery/3716-admission-webhook-match-conditions/README.md Outdated
- [ ] Request in scope without `matchConditions`, and also matching
- [ ] Multiple match conditions, covering the same cases as the single-condition case
- [X] Feature gate enablement / disablement is a no-op when no `matchConditions` are set
- [] Feature gate enablement / disablement works as expected when `matchConditions` are set
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is a TODO I believe, we have one for testing the fields on the API object but not the functionality of the match conditions based on feature gate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This might not matter now since we remove the feature gate and the feature is always on when we graduate to GA. Still, this edit is correct. Maybe expand it with a comment that this got missed in Beta and that since we're now targeting GA we're about to delete the feature gate and don't need this?

jpbetz
jpbetz requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small requests

keps/sig-api-machinery/3716-admission-webhook-match-conditions/README.md Outdated
- [ ] Request in scope without `matchConditions`, and also matching
- [ ] Multiple match conditions, covering the same cases as the single-condition case
- [X] Feature gate enablement / disablement is a no-op when no `matchConditions` are set
- [] Feature gate enablement / disablement works as expected when `matchConditions` are set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This might not matter now since we remove the feature gate and the feature is always on when we graduate to GA. Still, this edit is correct. Maybe expand it with a comment that this got missed in Beta and that since we're now targeting GA we're about to delete the feature gate and don't need this?

keps/sig-api-machinery/3716-admission-webhook-match-conditions/kep.yaml

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.27"
beta: "v1.28"
stable: "TBD"
stable: "v1.30"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also update keps/prod-readiness/sig-api-machinery/3716.yaml and add a stable: stanza?

keps/sig-api-machinery/3716-admission-webhook-match-conditions/README.md
GA requirements TBD
<<[/UNRESOLVED]>>
- Promote appropriate E2E tests to conformance
- Cover any missing test coverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have:

https://github.com/kubernetes/kubernetes/blob/a1ffdedf782edf1472102b0b99c1467d4ed39753/test/e2e/apimachinery/webhook.go#L715

Maybe throw the link into the KEP for other reviewers?

The test list is:

  • "should be able to create and update validating webhook configurations with match conditions"
  • "should be able to create and update mutating webhook configurations with match conditions"
  • "should reject validating webhook configurations with invalid match conditions"
  • "should reject mutating webhook configurations with invalid match conditions"
  • "should mutate everything except 'skip-me' configmaps"

I spent a few minutes and couldn't think of anything else to add. I think they all should be promoted to conformance.

@jpbetz
Copy link
Contributor

jpbetz commented Jan 25, 2024

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 25, 2024
deads2k
deads2k reviewed Jan 26, 2024
View reviewed changes
keps/sig-api-machinery/3716-admission-webhook-match-conditions/README.md
_NON-BLOCKING for Alpha_
Details TBD.
<<[/UNRESOLVED]>>
The per call limit is shared with Validating Admission Policy CEL expressions and set at roughly 0.1 second for each expression evaluation call. The total budget per object (i.e. per ValidatingWebhook) for CEL match conditions is roughly .25 seconds and 1/4 the budget of Validating Admission Policy limit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

cc @jpbetz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM as well

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 30, 2024
@ivelichkovich ivelichkovich marked this pull request as ready for review January 30, 2024 01:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
@ivelichkovich
Copy link
Contributor Author

addressed comments

@deads2k
Copy link
Contributor

deads2k commented Jan 30, 2024

PRR and update lgtm

/approve

I'll leave lgtm with @jpbetz who is also in here

/assign @jpbetz

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ivelichkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Jan 31, 2024

/lgtm

looks like my comments have been addressed

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 119187e into kubernetes:master Jan 31, 2024
4 checks passed
@jpbetz jpbetz mentioned this pull request Feb 6, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz requested changes

@deads2k deads2k deads2k left review comments

@apelisse apelisse Awaiting requested review from apelisse

@fedebongio fedebongio Awaiting requested review from fedebongio

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lead-opted-in Denotes that an issue has been opted in to a release lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivelichkovich @k8s-ci-robot @jpbetz @deads2k