Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4396: promote kep into implementable #4482

Merged
merged 2 commits into from
Feb 7, 2024
Merged

KEP-4396: promote kep into implementable #4482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c79690
promote kep 4396 into implementable
HirazawaUi Feb 6, 2024
904ce4d
trigger PRR for kep 4369
HirazawaUi Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions keps/prod-readiness/sig-node/4369.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# The KEP must have an approver from the
# "prod-readiness-approvers" group
# of http://git.k8s.io/enhancements/OWNERS_ALIASES
kep-number: 4369
alpha:
approver: "@jpbetz"
6 changes: 4 additions & 2 deletions keps/sig-node/4369-allow-special-characters-environment-variable/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,12 @@ These tests will be added:

- Solicit feedback from the Alpha.
- Ensure tests are stable and passing.
- Add monitor for pods that fail due to using enhancements.

#### GA

- No issues reported during two releases.
- Ensure that the time range of the beta version can cover the version skew of all components.
- Add troubleshooting details on how to deal with incompatible kubelet/CRI implementations based on issues found in beta releases.

### Upgrade / Downgrade Strategy

Expand Down Expand Up @@ -240,7 +242,7 @@ No.

### Monitoring Requirements

- N/A
- We will investigate in the beta version how to monitor kubelet/CRI implementations could fail on pods using this enhancement.

### Dependencies

Expand Down
5 changes: 3 additions & 2 deletions keps/sig-node/4369-allow-special-characters-environment-variable/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@ authors:
owning-sig: sig-node
participating-sigs:
- sig-api-machinery
status: provisional
status: implementable
creation-date: 2023-12-21
reviewers:
- "@liggitt"
- "@thockin"
- TBD
approvers:
- "@liggitt"
- "@thockin"
Expand All @@ -29,6 +28,8 @@ latest-milestone: "v1.30"
# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.30"
beta: "v1.32"
stable: "v1.36"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

36 is rather pessimistic, don't you think :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to soak the compatibility into all supported k8s versions, this might make sense? I don't know if that was the thinking here..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to soak the compatibility into all supported k8s versions, this might make sense

Yes, the intention is to have the beta version span four release cycle (the maximum range of version skew for our different components) to avoid compatibility issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is WAY more than we normally do for introducing new features

Copy link
Contributor

@jpbetz jpbetz Feb 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ratcheting, soak time can be counted starting at the initial alpha, because we always introduce "tolerate if read from storage" then. And that's what matters when soaking. So if we go to stable one release after beta (v1.33), we still have a full support soak window.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, I will modify it to version v1.33 later.


# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down