Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4396: promote kep into implementable #4482

Merged
merged 2 commits into from
Feb 7, 2024
Merged

KEP-4396: promote kep into implementable #4482

merged 2 commits into from
Feb 7, 2024

Conversation

HirazawaUi
Copy link
Contributor

  • One-line PR description: promote kep 4396 into implementable
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@HirazawaUi
Copy link
Contributor Author

/cc @thockin @jpbetz

@HirazawaUi HirazawaUi mentioned this pull request Feb 6, 2024
Open
6 tasks
@HirazawaUi
Copy link
Contributor Author

Do I need to close #4478 and merge it into the current PR and submit it together?

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Feb 6, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Feb 7, 2024

PRR looks OK for alpha

/approve

@HirazawaUi HirazawaUi mentioned this pull request Feb 7, 2024
Closed
@HirazawaUi
Copy link
Contributor Author

/assign @mrunalp

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, jpbetz, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
thockin
thockin reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 144af03 into kubernetes:master Feb 7, 2024
4 checks passed
SIG Node PR Triage automation moved this from Triage to Done Feb 7, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 7, 2024
thockin
thockin reviewed Feb 7, 2024
View reviewed changes
keps/sig-node/4369-allow-special-characters-environment-variable/kep.yaml
@@ -29,6 +28,8 @@ latest-milestone: "v1.30"
# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.30"
beta: "v1.32"
stable: "v1.36"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

36 is rather pessimistic, don't you think :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to soak the compatibility into all supported k8s versions, this might make sense? I don't know if that was the thinking here..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to soak the compatibility into all supported k8s versions, this might make sense

Yes, the intention is to have the beta version span four release cycle (the maximum range of version skew for our different components) to avoid compatibility issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is WAY more than we normally do for introducing new features

Copy link
Contributor

@jpbetz jpbetz Feb 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ratcheting, soak time can be counted starting at the initial alpha, because we always introduce "tolerate if read from storage" then. And that's what matters when soaking. So if we go to stable one release after beta (v1.33), we still have a full support soak window.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, I will modify it to version v1.33 later.

@HirazawaUi HirazawaUi mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@mrunalp mrunalp

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HirazawaUi @jpbetz @k8s-ci-robot @mrunalp @thockin