Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunAsGroup KEP #800

Merged
merged 2 commits into from
Feb 6, 2019
Merged

RunAsGroup KEP #800

merged 2 commits into from
Feb 6, 2019

Conversation

krmayankk
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/pm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2019
@krmayankk
Copy link
Author

/assign @liggitt

@krmayankk krmayankk mentioned this pull request Feb 1, 2019
Closed
5 tasks
liggitt
liggitt reviewed Feb 1, 2019
View reviewed changes
keps/sig-auth/20190131-runas-groupid.md Outdated
title: RunAsGroup support in PodSpec and PodSecurityPolicy
authors:
- "@krmayankk"
owning-sig: sig-auth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make sig-node owning and sig-auth participating

keps/sig-auth/20190131-runas-groupid.md Outdated
- "@pweil-"
approvers:
- "@pmorie"
- "@smarterclayton"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reviewer/approver list is outdated

@liggitt for auth/API, @derekwaynecarr for node is probably good

keps/sig-auth/20190131-runas-groupid.md Outdated
- "@smarterclayton"
- "@pmorie"
- "@php-coder"
- "@pweil-"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reviewer list is outdated, suggest @tallclair and @mrunalp

liggitt
liggitt reviewed Feb 1, 2019
View reviewed changes
keps/sig-auth/20190131-runas-groupid.md Outdated
editor: TBD
creation-date: 2017-06-21
last-updated: 2017-09-14
status: implemented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementable, still in beta

@liggitt
Copy link
Member

liggitt commented Feb 4, 2019

/lgtm
/approve

/hold
for sig-node ack
/cc @mrunalp @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2019
liggitt
liggitt reviewed Feb 4, 2019
View reviewed changes
keps/sig-auth/20190131-runas-groupid.md Outdated
title: RunAsGroup support in PodSpec and PodSecurityPolicy
authors:
- "@krmayankk"
owning-sig: sig-node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you move the file to keps/sig-node?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@liggitt liggitt changed the title wrap runas-groupid proposal into kep for 1.14 RunAsGroup KEP Feb 4, 2019
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2019
@liggitt
Copy link
Member

liggitt commented Feb 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2019
@derekwaynecarr
Copy link
Member

this is fine from my perspective.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, krmayankk, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2019
tallclair
tallclair reviewed Feb 5, 2019
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple formatting clean-ups.

keps/sig-node/20190131-runas-groupid.md
@@ -0,0 +1,44 @@
---
kep-number: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: delete this

keps/sig-node/20190131-runas-groupid.md
- "@derekwaynecarr"
editor: TBD
creation-date: 2017-06-21
last-updated: 2017-09-14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix

keps/sig-node/20190131-runas-groupid.md

# RunAsGroup support in PodSpec and PodSecurityPolicy

https://github.com/kubernetes/community/blob/master/contributors/design-proposals/auth/runas-groupid.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you copy most of the content from the design proposal to here? Preferably as a separate commit. The KEP should be the source-of-truth for the design.

keps/sig-node/20190131-runas-groupid.md

- Publish Test Results from Master Branch of Cri-o To http://prow.k8s.io [#72253](https://github.com/kubernetes/kubernetes/issues/72253)
- Containerd and CRI-O tests included in k/k CI [#72287](https://github.com/kubernetes/kubernetes/issues/72287)
- Make CRI tests failures as release informing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the criteria for beta or GA?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graduation i thought meant GA right ?

keps/sig-node/20190131-runas-groupid.md Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Feb 6, 2019

/hold cancel

Tim's comments would be good to address in a follow-up

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2019
@liggitt
Copy link
Member

liggitt commented Feb 6, 2019

/test pull-enhancements-verify

@k8s-ci-robot
Copy link
Contributor

@krmayankk: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-enhancements-verify 8fcfe76 link /test pull-enhancements-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Katharine
Copy link
Member

/skip

@k8s-ci-robot k8s-ci-robot merged commit 8033bda into kubernetes:master Feb 6, 2019
@krmayankk
Copy link
Author

@tallclair a follow up pr coming to address remaining comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@tallclair tallclair tallclair left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@liggitt liggitt

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@krmayankk @liggitt @derekwaynecarr @k8s-ci-robot @Katharine @tallclair @mrunalp @justaugustus