Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nfs-example] Use Deployments instead of ReplicationController #442

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

HusseinKabbout
Copy link
Contributor

According to the official kubernetes documentation it is recommended to use a Deployment instead of a ReplicationController to set up replication
https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/

According to the official kubernetes documentation it is recommended to use a Deployment instead of a ReplicationController to set up replication
https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 22, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: HusseinKabbout / name: hka (b89d392)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @HusseinKabbout!

It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/examples has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@sebgoa
Copy link
Contributor

sebgoa commented Mar 23, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HusseinKabbout, sebgoa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebgoa
Copy link
Contributor

sebgoa commented Mar 23, 2022

@HusseinKabbout thanks for this. you will need to fix your CLA for this to get merged

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 13cbf0b into kubernetes:master Mar 23, 2022
victtsl pushed a commit to victtsl/examples that referenced this pull request Dec 21, 2022
victtsl pushed a commit to victtsl/examples that referenced this pull request Dec 21, 2022
victtsl pushed a commit to victtsl/examples that referenced this pull request Dec 21, 2022
victtsl added a commit to victtsl/examples that referenced this pull request Jan 6, 2023
victtsl added a commit to victtsl/examples that referenced this pull request Jan 6, 2023
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2023
Updating README to reflect changes from #442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants