Support services that reference an external service #33

smarterclayton · 2016-07-19T20:01:33Z

Description

Services should be able to reference an external DNS address instead of only pods, which will allow application authors to reference services that exist off platform, on other clusters, or locally.

Owner @rata

Progress Tracker

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
and sometimes http://github.com/kubernetes/contrib, or other repos.
When you are done with the code, apply the "code-complete" label.
When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing. They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

Write user docs and get them merged in.
User docs go into http://github.com/kubernetes/kubernetes.github.io.
When the feature has user docs, please add a comment mentioning @kubernetes/docs.
When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.

The text was updated successfully, but these errors were encountered:

ncdc · 2016-07-25T14:58:07Z

@rata do you think you'll be able to code this in time for 1.4?

rata · 2016-07-25T16:04:38Z

On Mon, Jul 25, 2016 at 07:58:11AM -0700, Andy Goldstein wrote:

@rata do you think you'll be able to code this in time for 1.4?

My plan was to start working on this on Tuesday, as I have an exam on Tuesday at
university. IS this too late?

I think the change can be not so hard, for the quick look I had at th code (it
seems we just created a skydns backend in kube-dns, and seems is easy to add
another type response, CNAME, for what I looked).

But if you are concerned about this, please go ahead and work on this! I can
maybe join later and test or something :-)

ncdc · 2016-07-25T16:08:00Z

@rata that should be fine. I was just checking in. Thanks!

idvoretskyi · 2016-08-04T16:25:24Z

@smarterclayton @rata which SIG is responsible for this feature?

ncdc · 2016-08-04T16:50:49Z

I would assume network

idvoretskyi · 2016-08-04T16:58:28Z

@ncdc thanks

rata · 2016-08-04T17:03:55Z

@ncdc @smarterclayton @thockin I'm more busy than I expected (at $DAYJOB and university) and I'm not sure I'll make it on time on this. Do you want to start working on this, and if I have some time maybe jump on this later?

rata · 2016-08-04T19:19:47Z

I'm really really sorry, and I wish I could work on this, but I'm already late (planned to start 2 days ago) and more busy than I expected. I think it's better to say this early so this gets implemented in 1.4. But I'm really really sorry :-/

aronchick · 2016-08-04T20:40:49Z

@smarterclayton Do you think you can find someone else to tackle? Or should we just punt to 1.5.

therc · 2016-08-05T16:54:02Z

I'm also working on node-local services, so perhaps I can help with this. That way, I can blame myself for the ensuing rebases. :-)

rata · 2016-08-05T18:43:07Z

@therc thanks again! :)

idvoretskyi · 2016-08-05T20:45:52Z

@therc thank you for your help, assigned you as an assignee.

ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33

goltermann · 2016-08-17T20:47:40Z

In a meeting today, it was mentioned that this is missing v1.4. I'm moving to the v1.5 milestone. Please bring back to v1.4 if that's not accurate.

ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33

thockin · 2016-10-13T18:24:35Z

kubectl create service is the correct command tree to explore

On Thu, Oct 13, 2016 at 9:04 AM, Rudi C notifications@github.com wrote:

This is mostly working already in 1.4, but it occurred to me that there's
no way to create such a service from the command line without using a
YAML/JSON file.

kubectl expose doesn't feel exactly right, because the whole point of
ExternalName services is that there are no pods to be exposed. If that's
still the way it's going to be done, the command line syntax will have to
be changed from (-f FILENAME | TYPE NAME) ... to (-f FILENAME |
--external-name NAME | TYPE NAME) ....

Opening an issue for that.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVPmK08AXwK1Yw0eao88qgktxZ2Qiks5qzlaXgaJpZM4JQHJ2
.

aglassman · 2016-10-18T14:02:29Z

Thanks for working on this feature, it's been very helpful.

thockin · 2016-11-28T18:05:05Z

@therc I don't think the CLI for this went in, did it? Any reason to not call what we have GA, anyway? Are you active on the CLI part or should we just open a new issue for it?

jimmycuadra · 2016-12-13T02:28:42Z

This is stable in 1.5? Are there docs?

thockin · 2016-12-13T05:11:33Z

The CLI did not, but the API change is in 1.4. http://kubernetes.io/docs/user-guide/services/ - search for "ExternalName"

…

On Mon, Dec 12, 2016 at 6:28 PM, Jimmy Cuadra ***@***.***> wrote: This is stable in 1.5? Are there docs? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVKpwQ33RKcvMjd5az7o6_WdQP_VUks5rHgLcgaJpZM4JQHJ2> .

idvoretskyi · 2016-12-13T18:35:29Z

@smarterclayton @therc can you confirm the feature development has been completed and issue can be closed?

thockin · 2016-12-28T07:09:05Z

@therc Can we count on you for CLI wrapup? would love to close this...

idvoretskyi · 2017-01-05T17:24:23Z

@thockin @therc sooo, any final decision?

thockin · 2017-01-24T08:26:50Z

@therc ping?

…

On Thu, Jan 5, 2017 at 9:24 AM, Ihor Dvoretskyi ***@***.***> wrote: @thockin <https://github.com/thockin> @therc <https://github.com/therc> sooo, any final decision? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVB2ih9pim5d_LqxYdYzkyz-NZe7fks5rPSdKgaJpZM4JQHJ2> .

therc · 2017-01-24T17:27:25Z

Just got back from vacation and a hectic office move, working my way through email backlog.
I can pick up any leftover items, but I think kubectl create support was implemented by @adohe in kubernetes/kubernetes#34789
Was there anything else you had in mind? My next related step was allowing the built-in kubernetes.default service to also be an ExternalName service, to pave the way for a migration to api.kube-system or something along those lines. But if you have something else that's higher priority, I can tackle that first.

thockin · 2017-01-24T21:55:24Z

Oh, great, I missed that :) Can you cross-check the un-ticked boxes on here, and if everything is done, we can close this out?

…

On Tue, Jan 24, 2017 at 9:27 AM, Rudi C ***@***.***> wrote: Just got back from vacation and a hectic office move, working my way through email backlog. I can pick up any leftover items, but I think kubectl create support was implemented by @adohe <https://github.com/AdoHe> in kubernetes/kubernetes#34789 <kubernetes/kubernetes#34789> Was there anything else you had in mind? My next related step was allowing the built-in kubernetes.default service to also be an ExternalName service, to pave the way for a migration to api.kube-system or something along those lines. But if you have something else that's higher priority, I can tackle that first. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVF0ojvj2dhIgnMo1TSq-xF7Qmqvzks5rVjSBgaJpZM4JQHJ2> .

therc · 2017-01-25T02:05:10Z

Unfortunately, I think only Clayton or another owner can edit the issue description. I just went through the checklist and it looks to me like everything can be ticked off.

Regarding "detailed docs and examples", I have something with more use cases, originally for internal use, that I have almost entirely re-purposed as a blog post. I'm not sure how kosher it is to add links from Kubernetes docs to random external blog posts; I suspect not very, given link rot and the like. Perhaps I could re-adapt it again as a tutorial in the docs repo? This issue can be closed anyway.

thockin · 2017-01-25T02:16:10Z

DONE

idvoretskyi · 2017-01-26T14:41:55Z

@therc @thockin does this feature target 1.6 (as per @mdelio modified milestone) or it has been finally implemented in 1.5 yet?

If this is still 1.6, I'd like to reopen it and keep in this state during the release.

therc · 2017-01-26T14:49:42Z

The main feature is in 1.5 already and can be used through YAML files. It's the kubectl support that will land in 1.6. I think it'd be worthy of a 1.5 cherrypick.

adohe-zz · 2017-02-04T02:46:02Z

@idvoretskyi @therc yes, the kubectl support land in 1.6, shall we cherrypick it against 1.5?

liggitt · 2017-02-04T03:03:17Z

We don't typically backport new features

adohe-zz · 2017-02-04T04:15:13Z

Get it~

add open questions to the template

* Make TOC approval required for features in root Until we have better owners for the root of this, require TOC approval for changes. Also allow any maintainers to approve changes to /features. * Update CODEOWNERS

smarterclayton mentioned this issue Jul 19, 2016

Add proposal for service externalName kubernetes/kubernetes#29073

Merged

idvoretskyi added this to the v1.4 milestone Jul 20, 2016

idvoretskyi assigned smarterclayton Aug 4, 2016

idvoretskyi added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Aug 4, 2016

idvoretskyi assigned therc Aug 5, 2016

therc mentioned this issue Aug 6, 2016

Add node-local service affinity to API kubernetes/kubernetes#30190

Closed

therc mentioned this issue Aug 14, 2016

Add Service type "ExternalName" which results in CNAME DNS kubernetes/kubernetes#30599

Merged

goltermann modified the milestones: v1.5, v1.4 Aug 17, 2016

therc mentioned this issue Aug 18, 2016

Add ExternalName kube-dns e2e test kubernetes/kubernetes#30931

Merged

therc mentioned this issue Oct 13, 2016

ExternalName service support in kubectl kubernetes/kubernetes#34731

Closed

idvoretskyi added stable-in-1.5 and removed stable-in-1.4 labels Nov 17, 2016

idvoretskyi modified the milestones: next-milestone, v1.5 Dec 13, 2016

rantoniuk mentioned this issue Jan 10, 2017

Allow a service to resolve to a CNAME from DNS kubernetes/kubernetes#13748

Closed

mdelio modified the milestones: v1.6, next-milestone Jan 24, 2017

mdelio removed the (deprecated label - do not use) stable-in-1.5 label Jan 24, 2017

thockin closed this as completed Jan 25, 2017

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020

Merge pull request kubernetes#33 from deads2k/open

9773282

add open questions to the template

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support services that reference an external service #33

Support services that reference an external service #33

smarterclayton commented Jul 19, 2016 •

edited by thockin

ncdc commented Jul 25, 2016

rata commented Jul 25, 2016

ncdc commented Jul 25, 2016

idvoretskyi commented Aug 4, 2016 •

edited

ncdc commented Aug 4, 2016

idvoretskyi commented Aug 4, 2016

rata commented Aug 4, 2016

rata commented Aug 4, 2016

aronchick commented Aug 4, 2016

therc commented Aug 5, 2016

rata commented Aug 5, 2016

idvoretskyi commented Aug 5, 2016

goltermann commented Aug 17, 2016

thockin commented Oct 13, 2016

aglassman commented Oct 18, 2016

thockin commented Nov 28, 2016

jimmycuadra commented Dec 13, 2016

thockin commented Dec 13, 2016 via email

idvoretskyi commented Dec 13, 2016

thockin commented Dec 28, 2016

idvoretskyi commented Jan 5, 2017

thockin commented Jan 24, 2017 via email

therc commented Jan 24, 2017

thockin commented Jan 24, 2017 via email

therc commented Jan 25, 2017

thockin commented Jan 25, 2017

idvoretskyi commented Jan 26, 2017

therc commented Jan 26, 2017

adohe-zz commented Feb 4, 2017

liggitt commented Feb 4, 2017

adohe-zz commented Feb 4, 2017

Support services that reference an external service #33

Support services that reference an external service #33

Comments

smarterclayton commented Jul 19, 2016 • edited by thockin

Description

Progress Tracker

ncdc commented Jul 25, 2016

rata commented Jul 25, 2016

ncdc commented Jul 25, 2016

idvoretskyi commented Aug 4, 2016 • edited

ncdc commented Aug 4, 2016

idvoretskyi commented Aug 4, 2016

rata commented Aug 4, 2016

rata commented Aug 4, 2016

aronchick commented Aug 4, 2016

therc commented Aug 5, 2016

rata commented Aug 5, 2016

idvoretskyi commented Aug 5, 2016

goltermann commented Aug 17, 2016

thockin commented Oct 13, 2016

aglassman commented Oct 18, 2016

thockin commented Nov 28, 2016

jimmycuadra commented Dec 13, 2016

thockin commented Dec 13, 2016 via email

idvoretskyi commented Dec 13, 2016

thockin commented Dec 28, 2016

idvoretskyi commented Jan 5, 2017

thockin commented Jan 24, 2017 via email

therc commented Jan 24, 2017

thockin commented Jan 24, 2017 via email

therc commented Jan 25, 2017

thockin commented Jan 25, 2017

idvoretskyi commented Jan 26, 2017

therc commented Jan 26, 2017

adohe-zz commented Feb 4, 2017

liggitt commented Feb 4, 2017

adohe-zz commented Feb 4, 2017

smarterclayton commented Jul 19, 2016 •

edited by thockin

idvoretskyi commented Aug 4, 2016 •

edited