Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to persuade people to backup etcd #234

Merged
merged 2 commits into from Mar 27, 2017
Merged

Try to persuade people to backup etcd #234

merged 2 commits into from Mar 27, 2017

Conversation

justinsb
Copy link
Member

We really need people to back up before attempting this upgrade, and to understand the scenarios where there is no alternative but to restore from backup.

I hope this is enough to persuade users that a backup really is needed this time, but I worry that it's still not enough.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2017
@justinsb justinsb added this to the v1.6 milestone Mar 26, 2017
@justinsb
Copy link
Member Author

justinsb commented Mar 26, 2017

be migrated at the current time using the official kubernetes procedure.

1.6 will also default to protobuf encoding if using etcd3. This change is
irreversible. To rollback, you must restore from a backup made before the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put This change is irreversible in bold.

@idvoretskyi idvoretskyi self-assigned this Mar 26, 2017
@idvoretskyi
Copy link
Member

@justinsb will be merged after the review.

@justinsb
Copy link
Member Author

Thanks @pwittrock - emboldened "This change is irreversible".

To me, "HA installations cannot be migrated at the current time using the official kubernetes procedure" is even worse - we are nuking anyone that upgrades their HA kube-up cluster - but we did say that was alpha https://kubernetes.io/docs/admin/ha-master-gce/

@ethernetdan
Copy link
Contributor

To me, "HA installations cannot be migrated at the current time using the official kubernetes procedure" is even worse - we are nuking anyone that upgrades their HA kube-up cluster - but we did say that was alpha https://kubernetes.io/docs/admin/ha-master-gce/

Agreed - it's definitely unfortunate we have to have cluster turndown for upgrade there. The change of media types requires a cluster bringdown because AFAIK there's no support for mixed media types on the API server so disruption of HA is currently inevitable.

@justinsb
Copy link
Member Author

To be clear, I believe that GCE kube-up users that followed https://kubernetes.io/docs/admin/ha-master-gce/ and try to upgrade will have their clusters destroyed. Best case, the upgrade fails and they are stuck on 1.5.

Puts a few minutes downtime into perspective...

@wojtek-t
Copy link
Member

To me, "HA installations cannot be migrated at the current time using the official kubernetes procedure" is even worse - we are nuking anyone that upgrades their HA kube-up cluster - but we did say that was alpha https://kubernetes.io/docs/admin/ha-master-gce/

Agreed - it's definitely unfortunate we have to have cluster turndown for upgrade there. The change of media types requires a cluster bringdown because AFAIK there's no support for mixed media types on the API server so disruption of HA is currently inevitable.

I think there may be some misunderstanding here.
The cluster turndown (which I agree is unfortunate) is not about changing the media type from json to protobufs (which we call media type). And we can leave with part of objects be still stored in json and the other part in protobufs.
The cluster turndown is fully because migration to etcd v3.

@justinsb
Copy link
Member Author

Rebased

@calebamiles
Copy link
Contributor

merging this warning as is, @justinsb, @wojtek-t, @ethernetdan please open another PR for further changes.

cc: @idvoretskyi, @kubernetes/kubernetes-release-managers

@calebamiles calebamiles merged commit e03c384 into master Mar 27, 2017
@idvoretskyi idvoretskyi deleted the backup_warning branch January 4, 2018 23:49
ingvagabund pushed a commit to ingvagabund/enhancements that referenced this pull request Apr 2, 2020
monitoring: user-workload-monitoring GA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants