New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to persuade people to backup etcd #234
Conversation
release-1.6/release-notes-draft.md
Outdated
be migrated at the current time using the official kubernetes procedure. | ||
|
||
1.6 will also default to protobuf encoding if using etcd3. This change is | ||
irreversible. To rollback, you must restore from a backup made before the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put This change is irreversible in bold.
@justinsb will be merged after the review. |
32eb372
to
337a5f5
Compare
Thanks @pwittrock - emboldened "This change is irreversible". To me, "HA installations cannot be migrated at the current time using the official kubernetes procedure" is even worse - we are nuking anyone that upgrades their HA kube-up cluster - but we did say that was alpha https://kubernetes.io/docs/admin/ha-master-gce/ |
Agreed - it's definitely unfortunate we have to have cluster turndown for upgrade there. The change of media types requires a cluster bringdown because AFAIK there's no support for mixed media types on the API server so disruption of HA is currently inevitable. |
To be clear, I believe that GCE kube-up users that followed https://kubernetes.io/docs/admin/ha-master-gce/ and try to upgrade will have their clusters destroyed. Best case, the upgrade fails and they are stuck on 1.5. Puts a few minutes downtime into perspective... |
I think there may be some misunderstanding here. |
Embolden "This change is irreversible"
337a5f5
to
b334cc3
Compare
Rebased |
merging this warning as is, @justinsb, @wojtek-t, @ethernetdan please open another PR for further changes. cc: @idvoretskyi, @kubernetes/kubernetes-release-managers |
monitoring: user-workload-monitoring GA
We really need people to back up before attempting this upgrade, and to understand the scenarios where there is no alternative but to restore from backup.
I hope this is enough to persuade users that a backup really is needed this time, but I worry that it's still not enough.