Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Would like to see example yaml snippet for GCP certificate resource for SSL/TLS #229

Closed
jdyer09 opened this issue Apr 18, 2018 · 5 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jdyer09
Copy link

jdyer09 commented Apr 18, 2018

I'm assuming it would look like such, but it is somewhat unclear:

kind: Ingress
metadata:
  name: no-rules-map
  annotations:
    ingress.gcp.kubernetes.io/pre-shared-cert: "example.com-cert"
spec:
  backend:
    serviceName: s1
    servicePort: 443
@jdyer09
Copy link
Author

jdyer09 commented Apr 18, 2018

Also, noting that crt and key input cannot have newlines in the encoding would be useful.
Suggestion:

kind: Secret
metadata:
  name: testsecret
  namespace: default
type: Opaque
data:
  tls.crt: base64 encoded cert # note that newlines are not allowed in the encoding.  Try $ cat example.com.crt | tr -d "\n" | base64
  tls.key: base64 encoded key # The same is true as the cert about not allowing newline characters

@nicksardo nicksardo added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 16, 2018
@TheWolfNL
Copy link

It's already visible in the README.md here:
https://github.com/kubernetes/ingress-gce/blob/master/README.md#frontend-https

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2018
@rramkumar1
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants