Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for backend service update #1709

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix for backend service update #1709

merged 1 commit into from
May 17, 2022

Conversation

kl52752
Copy link
Contributor

@kl52752 kl52752 commented May 9, 2022

We should update backend service with ig llinks
only when ig links changed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @kl52752. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2022
cezarygerard
cezarygerard approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@cezarygerard cezarygerard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cezarygerard
Copy link
Contributor

@bowei ping we need this PR for RBS launch

@kl52752
Copy link
Contributor Author

kl52752 commented May 12, 2022

/assign @bowei

@bowei
Copy link
Member

bowei commented May 16, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2022
@bowei
Copy link
Member

bowei commented May 16, 2022

Let's fix the commit message so that the change is obvious when looking at the git history:

Only update BackendService IG links when they change

<more details...>

bowei
bowei reviewed May 16, 2022
View reviewed changes
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Let's add logging so if there is an issue with this code path, we have enough information to debug.

pkg/backends/regional_ig_linker.go Show resolved Hide resolved
pkg/backends/regional_ig_linker.go Show resolved Hide resolved
pkg/backends/regional_ig_linker.go Show resolved Hide resolved
pkg/backends/regional_ig_linker.go Show resolved Hide resolved
@kl52752
Only update BackendService IG links when they change
be51a30 
We should update backend service with ig links
only when ig links changed.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2022
@kl52752 kl52752 requested a review from bowei May 17, 2022 11:16
bowei
bowei reviewed May 17, 2022
View reviewed changes
pkg/backends/regional_ig_linker.go
}
if len(addIGs) == 0 {
klog.V(3).Infof("No backends to add for %s, skipping update.", sp.BackendName())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this at V(2) so it appears in the normal log? Is it too noisy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this as a follow up

pkg/backends/regional_ig_linker.go

if err := linker.backendPool.Update(be); err != nil {
bs.Backends = newBackends
klog.V(3).Infof("Update Backend %s, with %d backends.", sp.BackendName(), len(addIGs))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here V(2)

@bowei
Copy link
Member

bowei commented May 17, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, cezarygerard, kl52752, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 99288fa into kubernetes:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@cezarygerard cezarygerard cezarygerard approved these changes

@panslava panslava panslava approved these changes

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kl52752 @k8s-ci-robot @cezarygerard @bowei @panslava