fix a bug where ingress GC will remove wanted LB if the namespace+nam… #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bowei
reviewed
Mar 14, 2019
pkg/loadbalancers/l7s_test.go
Outdated
| expectLBs []string | ||
| }{ | ||
| { | ||
| "empty", |
There was a problem hiding this comment.
can we use the labeled struct format, I find this hard to follow
desc: "...",
keys: []string{...}
pkg/loadbalancers/l7s_test.go
Outdated
| desc string | ||
| keys []string | ||
| existingLBs []string | ||
| expectLBs []string |
There was a problem hiding this comment.
extraExpectedLBs (any in ingressLBs must appear here, don't need to specify them separately.
pkg/loadbalancers/l7s_test.go
Outdated
| testCases := []struct { | ||
| desc string | ||
| keys []string | ||
| existingLBs []string |
pkg/loadbalancers/l7s_test.go
Outdated
| cloud := l7sPool.cloud | ||
| testCases := []struct { | ||
| desc string | ||
| keys []string |
pkg/loadbalancers/l7s_test.go
Outdated
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| for _, key := range tc.existingLBs { |
There was a problem hiding this comment.
tc := tc
t.Run(tc.desc, func(t*testing.T){
...
})
|
Ready for another round |
bowei
reviewed
Mar 14, 2019
|
Pushed |
…e length is between 44-47 chars
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 15, 2019
Cherry pick #688 into release.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a bug where ingress GC will remove wanted LB if the namespace+name length is between 44-47 chars Introduced by this commit: c74db67#diff-b1f4c09e8d55ceb3fe65799b21e57d43