http2 option for http server

[stamm]

NGINX Ingress controller version: 0.26.1

I use ingress as balancer for grpc without tls, and before this version I was able to patch nginx.tmpl to add http2 flag to listen option

 listen {{ $all.ListenPorts.HTTP }}{{ if $all.Cfg.UseProxyProtocol }} proxy_protocol{{ end }}{{ if eq $server.Hostname "_"}} default_server {{ if $all.Cfg.ReusePort }}reuseport{{ end }} backlog={{ $all.BacklogSize }}{{end}}{{ if $all.Cfg.UseHTTP2 }} http2{{ end }};

{{ if $all.Cfg.UseHTTP2 }} http2{{ end }}

But now this block is generated by go code.

[aledbf]

@stamm there is no support for autodetection of http1.x and http2 in nginx itself. Please check
https://forum.nginx.org/read.php?29,278877,278929#msg-278929

With this change, we break http1 without tls.

#3897
#3938
#2465

(I posted the same comment in the PR).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[Audrius-GR]

If the backend-protocol annotation specifies GRPC, would it make sense to force it to http2 in that case?
Atleast it would fix the GRPC case.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.