Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Rework network policies. #10238

Merged
merged 1 commit into from Sep 24, 2023
Merged

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jul 22, 2023

What this PR does / why we need it:

This PR reworks the existing controller network policy which was added for the admission webhook to restrict access on all known ports instead of allowing any and adds a network policy for the default backend.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2023
@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 50f1c48
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/650db926f65f7b0007f080aa

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Gacko. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/helm Issues or PRs related to helm charts needs-priority labels Jul 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2023
@Gacko
Copy link
Member Author

Gacko commented Jul 22, 2023

@tao12345666333: I opened this PR in favor of #9634 since the base repository changed.

@Gacko Gacko mentioned this pull request Jul 22, 2023
11 tasks
@Gacko Gacko force-pushed the pull/1 branch 2 times, most recently from f1a4039 to a86b47c Compare July 31, 2023 08:35
@Gacko Gacko changed the title Chart: Rework NetworkPolicies. Chart: Rework network policies. Aug 2, 2023
@Gacko Gacko force-pushed the pull/1 branch 3 times, most recently from a682dc2 to 62c781f Compare August 8, 2023 17:11
@Gacko Gacko force-pushed the pull/1 branch 2 times, most recently from 2baba65 to 1eac915 Compare August 24, 2023 13:15
@Gacko
Copy link
Member Author

Gacko commented Aug 26, 2023

@tao12345666333: Is there anything I can do to get this merged? IMHO this is not breaking anything as long as one has not enabled network policies, but fixes stuff for those who have. So in the end it's a win-win even though it might be a little breaking due to removing/renaming the old config key.

This PR / the original PR is already open since February 15 this year, so longer than half a year, and many other PRs opened later than mine got merged in the meantime. Is there any reason for this? Can I support you with reviewing it?

@Gacko Gacko force-pushed the pull/1 branch 4 times, most recently from fc1ce4f to 833f1a7 Compare August 31, 2023 14:06
@Gacko Gacko force-pushed the pull/1 branch 6 times, most recently from 3c3015d to fb96856 Compare September 10, 2023 16:20
@Gacko Gacko force-pushed the pull/1 branch 6 times, most recently from 77cd93d to 6cf3a97 Compare September 18, 2023 05:16
@Gacko Gacko force-pushed the pull/1 branch 5 times, most recently from e726323 to 86b1a0b Compare September 18, 2023 16:26
@strongjz
Copy link
Member

/lgtm
/cherry-pick release-1.9

@k8s-infra-cherrypick-robot

@strongjz: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/lgtm
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0b0ce03 into kubernetes:main Sep 24, 2023
40 checks passed
@k8s-infra-cherrypick-robot

@strongjz: new pull request created: #10438

In response to this:

/lgtm
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants