New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Rework network policies. #10238
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Gacko. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tao12345666333: I opened this PR in favor of #9634 since the base repository changed. |
f1a4039
to
a86b47c
Compare
a682dc2
to
62c781f
Compare
2baba65
to
1eac915
Compare
@tao12345666333: Is there anything I can do to get this merged? IMHO this is not breaking anything as long as one has not enabled network policies, but fixes stuff for those who have. So in the end it's a win-win even though it might be a little breaking due to removing/renaming the old config key. This PR / the original PR is already open since February 15 this year, so longer than half a year, and many other PRs opened later than mine got merged in the meantime. Is there any reason for this? Can I support you with reviewing it? |
fc1ce4f
to
833f1a7
Compare
3c3015d
to
fb96856
Compare
77cd93d
to
6cf3a97
Compare
e726323
to
86b1a0b
Compare
/lgtm |
@strongjz: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@strongjz: new pull request created: #10438 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR reworks the existing controller network policy which was added for the admission webhook to restrict access on all known ports instead of allowing any and adds a network policy for the default backend.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: